Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: src/crankshaft/typing.cc

Issue 1592713002: Clean up dead code after spread desugaring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix bug that visited dead AST node in for/of Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/typing.h" 5 #include "src/crankshaft/typing.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/frames.h" 8 #include "src/frames.h"
9 #include "src/frames-inl.h" 9 #include "src/frames-inl.h"
10 #include "src/ostreams.h" 10 #include "src/ostreams.h"
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 NarrowLowerType(expr->right(), right_type); 745 NarrowLowerType(expr->right(), right_type);
746 expr->set_combined_type(combined_type); 746 expr->set_combined_type(combined_type);
747 747
748 RECURSE(Visit(expr->left())); 748 RECURSE(Visit(expr->left()));
749 RECURSE(Visit(expr->right())); 749 RECURSE(Visit(expr->right()));
750 750
751 NarrowType(expr, Bounds(Type::Boolean(zone()))); 751 NarrowType(expr, Bounds(Type::Boolean(zone())));
752 } 752 }
753 753
754 754
755 void AstTyper::VisitSpread(Spread* expr) { RECURSE(Visit(expr->expression())); } 755 void AstTyper::VisitSpread(Spread* expr) { UNREACHABLE(); }
756 756
757 757
758 void AstTyper::VisitEmptyParentheses(EmptyParentheses* expr) { 758 void AstTyper::VisitEmptyParentheses(EmptyParentheses* expr) {
759 UNREACHABLE(); 759 UNREACHABLE();
760 } 760 }
761 761
762 762
763 void AstTyper::VisitThisFunction(ThisFunction* expr) { 763 void AstTyper::VisitThisFunction(ThisFunction* expr) {}
764 }
765 764
766 765
767 void AstTyper::VisitSuperPropertyReference(SuperPropertyReference* expr) {} 766 void AstTyper::VisitSuperPropertyReference(SuperPropertyReference* expr) {}
768 767
769 768
770 void AstTyper::VisitSuperCallReference(SuperCallReference* expr) {} 769 void AstTyper::VisitSuperCallReference(SuperCallReference* expr) {}
771 770
772 771
773 void AstTyper::VisitRewritableAssignmentExpression( 772 void AstTyper::VisitRewritableAssignmentExpression(
774 RewritableAssignmentExpression* expr) { 773 RewritableAssignmentExpression* expr) {
(...skipping 21 matching lines...) Expand all
796 void AstTyper::VisitImportDeclaration(ImportDeclaration* declaration) { 795 void AstTyper::VisitImportDeclaration(ImportDeclaration* declaration) {
797 } 796 }
798 797
799 798
800 void AstTyper::VisitExportDeclaration(ExportDeclaration* declaration) { 799 void AstTyper::VisitExportDeclaration(ExportDeclaration* declaration) {
801 } 800 }
802 801
803 802
804 } // namespace internal 803 } // namespace internal
805 } // namespace v8 804 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698