Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1592713002: Clean up dead code after spread desugaring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix bug that visited dead AST node in for/of Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-loop-assignment-analyzer.h" 5 #include "src/compiler/ast-loop-assignment-analyzer.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/parsing/parser.h" 7 #include "src/parsing/parser.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 Visit(e->right()); 191 Visit(e->right());
192 } 192 }
193 193
194 194
195 void ALAA::VisitCompareOperation(CompareOperation* e) { 195 void ALAA::VisitCompareOperation(CompareOperation* e) {
196 Visit(e->left()); 196 Visit(e->left());
197 Visit(e->right()); 197 Visit(e->right());
198 } 198 }
199 199
200 200
201 void ALAA::VisitSpread(Spread* e) { Visit(e->expression()); } 201 void ALAA::VisitSpread(Spread* e) { UNREACHABLE(); }
202 202
203 203
204 void ALAA::VisitEmptyParentheses(EmptyParentheses* e) { UNREACHABLE(); } 204 void ALAA::VisitEmptyParentheses(EmptyParentheses* e) { UNREACHABLE(); }
205 205
206 206
207 void ALAA::VisitCaseClause(CaseClause* cc) { 207 void ALAA::VisitCaseClause(CaseClause* cc) {
208 if (!cc->is_default()) Visit(cc->label()); 208 if (!cc->is_default()) Visit(cc->label());
209 VisitStatements(cc->statements()); 209 VisitStatements(cc->statements());
210 } 210 }
211 211
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 Visit(loop->subject()); 259 Visit(loop->subject());
260 Visit(loop->body()); 260 Visit(loop->body());
261 Exit(loop); 261 Exit(loop);
262 } 262 }
263 263
264 264
265 void ALAA::VisitForOfStatement(ForOfStatement* loop) { 265 void ALAA::VisitForOfStatement(ForOfStatement* loop) {
266 Visit(loop->assign_iterator()); 266 Visit(loop->assign_iterator());
267 Enter(loop); 267 Enter(loop);
268 Visit(loop->assign_each()); 268 Visit(loop->assign_each());
269 Visit(loop->each());
270 Visit(loop->subject()); 269 Visit(loop->subject());
271 Visit(loop->body()); 270 Visit(loop->body());
272 Exit(loop); 271 Exit(loop);
273 } 272 }
274 273
275 274
276 void ALAA::VisitAssignment(Assignment* stmt) { 275 void ALAA::VisitAssignment(Assignment* stmt) {
277 Expression* l = stmt->target(); 276 Expression* l = stmt->target();
278 Visit(l); 277 Visit(l);
279 Visit(stmt->value()); 278 Visit(stmt->value());
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 int count = 0; 313 int count = 0;
315 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var); 314 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var);
316 for (size_t i = 0; i < list_.size(); i++) { 315 for (size_t i = 0; i < list_.size(); i++) {
317 if (list_[i].second->Contains(var_index)) count++; 316 if (list_[i].second->Contains(var_index)) count++;
318 } 317 }
319 return count; 318 return count;
320 } 319 }
321 } // namespace compiler 320 } // namespace compiler
322 } // namespace internal 321 } // namespace internal
323 } // namespace v8 322 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698