Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: src/ast/ast-literal-reindexer.cc

Issue 1592713002: Clean up dead code after spread desugaring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix bug that visited dead AST node in for/of Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast/ast-literal-reindexer.h" 5 #include "src/ast/ast-literal-reindexer.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 } 181 }
182 182
183 183
184 void AstLiteralReindexer::VisitCompareOperation(CompareOperation* node) { 184 void AstLiteralReindexer::VisitCompareOperation(CompareOperation* node) {
185 Visit(node->left()); 185 Visit(node->left());
186 Visit(node->right()); 186 Visit(node->right());
187 } 187 }
188 188
189 189
190 void AstLiteralReindexer::VisitSpread(Spread* node) { 190 void AstLiteralReindexer::VisitSpread(Spread* node) {
191 // This is reachable because ParserBase::ParseArrowFunctionLiteral calls
192 // ReindexLiterals before calling RewriteDestructuringAssignments.
191 Visit(node->expression()); 193 Visit(node->expression());
192 } 194 }
193 195
194 196
195 void AstLiteralReindexer::VisitEmptyParentheses(EmptyParentheses* node) {} 197 void AstLiteralReindexer::VisitEmptyParentheses(EmptyParentheses* node) {}
196 198
197 199
198 void AstLiteralReindexer::VisitForInStatement(ForInStatement* node) { 200 void AstLiteralReindexer::VisitForInStatement(ForInStatement* node) {
199 Visit(node->each()); 201 Visit(node->each());
200 Visit(node->enumerable()); 202 Visit(node->enumerable());
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 void AstLiteralReindexer::VisitFunctionLiteral(FunctionLiteral* node) { 325 void AstLiteralReindexer::VisitFunctionLiteral(FunctionLiteral* node) {
324 // We don't recurse into the declarations or body of the function literal: 326 // We don't recurse into the declarations or body of the function literal:
325 } 327 }
326 328
327 329
328 void AstLiteralReindexer::Reindex(Expression* pattern) { 330 void AstLiteralReindexer::Reindex(Expression* pattern) {
329 pattern->Accept(this); 331 pattern->Accept(this);
330 } 332 }
331 } // namespace internal 333 } // namespace internal
332 } // namespace v8 334 } // namespace v8
OLDNEW
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698