Small improvements to Looper Idle tracing

Small improvements to Looper Idle tracing

- Avoid overlapping the Looper.queueIdle with the first task run
  post-idle
- include consistent stats in every queueIdle trace, and just do the
  burst logging info via an instant() trace

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205588

[Andrew Hayden (chromium.org), 2013-06-08 08:32:07]

Thanks for cleaning this up a bit.

One problem with this is "about://tracing" support for "instant" events which,
AFAIK, currently isn't working very well. I tried putting instant traces in for
this and wasn't able to see them on my linux desktop. Are you able to see these
in your about://tracing screen?

It's really nice to have this data in front of you on the trace diagram when
you're analyzing performance.

https://codereview.chromium.org/15927042/diff/1/content/public/android/java/s...
File content/public/android/java/src/org/chromium/content/common/TraceEvent.java
(right):

https://codereview.chromium.org/15927042/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:138:
TraceEvent.begin(IDLE_EVENT_NAME, "Tasks since last idle " +
mNumTasksSinceLastIdle);
nit:
mNumTasksSinceLastIdle + " tasks since last idle"
or
"Tasks since last idle: " + mNumTasksSinceLastIdle

[joth, 2013-06-10 20:36:49]

thanks!
+nilesh for owners stamp



On 8 June 2013 01:32, <andrewhayden@chromium.org> wrote:

> Thanks for cleaning this up a bit.
>
> One problem with this is "about://tracing" support for "instant" events
> which,
> AFAIK, currently isn't working very well. I tried putting instant traces
> in for
> this and wasn't able to see them on my linux desktop. Are you able to see
> these
> in your about://tracing screen?
>
>
Yes - you have to zoom way in to see them (they're little  triangles). It
would be helpful if they could be found more easily,  but OTOH this is
something of a feature rather than bug: it avoids cluttering virtual space
with additional call stack 'layers' for something that only a few people
will want to look for.



> It's really nice to have this data in front of you on the trace diagram
> when
> you're analyzing performance.
>
>
> https://codereview.chromium.**org/15927042/diff/1/content/**
>
public/android/java/src/org/**chromium/content/common/**TraceEvent.java<https://codereview.chromium.org/15927042/diff/1/content/public/android/java/src/org/chromium/content/common/TraceEvent.java>
> File
> content/public/android/java/**src/org/chromium/content/**
> common/TraceEvent.java
> (right):
>
> https://codereview.chromium.**org/15927042/diff/1/content/**
> public/android/java/src/org/**chromium/content/common/**
>
TraceEvent.java#newcode138<https://codereview.chromium.org/15927042/diff/1/content/public/android/java/src/org/chromium/content/common/TraceEvent.java#newcode138>
> content/public/android/java/**src/org/chromium/content/**
> common/TraceEvent.java:138:
>
> TraceEvent.begin(IDLE_EVENT_**NAME, "Tasks since last idle " +
> mNumTasksSinceLastIdle);
> nit:
> mNumTasksSinceLastIdle + " tasks since last idle"
>

done.





> or
>
> "Tasks since last idle: " + mNumTasksSinceLastIdle
>
>
https://codereview.chromium.**org/15927042/<https://codereview.chromium.org/1...
>

[nilesh, 2013-06-10 20:46:26]

On 2013/06/10 20:36:49, joth wrote:
> thanks!
> +nilesh for owners stamp
> 
LGTM

[commit-bot: I haz the power, 2013-06-10 22:17:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/15927042/5001

[commit-bot: I haz the power, 2013-06-11 06:30:37]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-06-11 18:06:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/15927042/5001

[commit-bot: I haz the power, 2013-06-11 18:06:51]

Change committed as 205588