Enabled using viewport on desktop browsers behind experimental flag

Source/WebKit/chromium/public/WebSettings.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 34 matching lines @@
 // these functions have a 1:1 mapping with the methods in WebCore/page/Settings.h.
 class WebSettings {
 public:
     enum EditingBehavior {
         EditingBehaviorMac,
         EditingBehaviorWin,
         EditingBehaviorUnix,
         EditingBehaviorAndroid
     };
 
+    virtual bool desktopViewportEnabled() const = 0;

[Rick Byers, 2013/06/04 00:25:30]

how does the semantics of this differ from viewportEnabled?  I.e. would you
expect ChromeOS to set all 3 of these flag (viewportEnabled,
desktopViewportEnabled AND deviceSupportsRotation) or some subset of them?

[bokan, 2013/06/04 18:52:16]

desktopViewportEnabled turns on viewportEnabled but all the layout resizing I
added is behind desktopViewportEnabled so that none of the Android behaviour
changes. I didn't realize that rotation happened on anything but Android. I'm
not sure what we want to do with rotation on CrOS but if we want to support
rotation behaviour like Android (so that the viewport gets appropriately
rescaled) we'll need some additional signal that a resize came from a rotation.
Enabling rotation on CrOS right now means resizing a window causes inappropriate
scaling rather than creating scrollbars.

[Rick Byers, 2013/06/05 15:04:08]

I think it's fine to treat rotation the same as normal window resize on CrOS. 
So I think this is mostly about picking better names for the setting.  Try to
focus the settings on the behavior that's affected, as opposed to properties of
the embedder.  Maybe it's 'resizePreservesViewportWidth' or something like that?

[bokan, 2013/06/06 19:43:47]

Changed it to resizeAffectsLayoutWidth

+    virtual bool deviceSupportsRotation() const = 0;
     virtual bool scrollAnimatorEnabled() const = 0;
     virtual bool touchEditingEnabled() const = 0;
     virtual bool viewportEnabled() const = 0;
     virtual void setAccelerated2dCanvasEnabled(bool) = 0;
     virtual void setAcceleratedCompositingEnabled(bool) = 0;
     virtual void setAcceleratedCompositingFor3DTransformsEnabled(bool) = 0;
     virtual void setAcceleratedCompositingForAnimationEnabled(bool) = 0;
     virtual void setAcceleratedCompositingForCanvasEnabled(bool) = 0;
     virtual void setAcceleratedCompositingForFixedPositionEnabled(bool)  = 0;
     virtual void setAcceleratedCompositingForOverflowScrollEnabled(bool) = 0;
@@ skipping 17 matching lines @@
     virtual void setCookieEnabled(bool) = 0;
     virtual void setCursiveFontFamily(const WebString&, UScriptCode = USCRIPT_COMMON) = 0;
     virtual void setDNSPrefetchingEnabled(bool) = 0;
     virtual void setDOMPasteAllowed(bool) = 0;
     virtual void setDefaultFixedFontSize(int) = 0;
     virtual void setDefaultFontSize(int) = 0;
     virtual void setDefaultTextEncodingName(const WebString&) = 0;
     virtual void setDefaultVideoPosterURL(const WebString&) = 0;
     void setDeferred2dCanvasEnabled(bool) { } // temporary stub
     virtual void setDeferredImageDecodingEnabled(bool) = 0;
+    virtual void setDesktopViewportEnabled(bool) = 0;
     virtual void setDeviceSupportsMouse(bool) = 0;
+    virtual void setDeviceSupportsRotation(bool) = 0;
     virtual void setDeviceSupportsTouch(bool) = 0;
     virtual void setDoubleTapToZoomEnabled(bool) = 0;
     virtual void setDownloadableBinaryFontsEnabled(bool) = 0;
     virtual void setEditableLinkBehaviorNeverLive() = 0;
     virtual void setEditingBehavior(EditingBehavior) = 0;
     virtual void setEnableScrollAnimator(bool) = 0;
     virtual void setEnableTouchAdjustment(bool) = 0;
     virtual void setExperimentalCSSCustomFilterEnabled(bool) = 0;
     virtual void setExperimentalCSSGridLayoutEnabled(bool) = 0;
     virtual void setCSSStickyPositionEnabled(bool) = 0;
@@ skipping 75 matching lines @@
     void setFixedElementsLayoutRelativeToFrame(bool) { }
     void setInitializeAtMinimumPageScale(bool enabled) { setLoadWithOverviewMode(enabled); }
 
 protected:
     ~WebSettings() { }
 };
 
 } // namespace WebKit
 
 #endif