Issue 159261: When closing the download shelf, hide the buttons of the dangerous download w...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159261: When closing the download shelf, hide the buttons of the dangerous download w... (Closed)

Created:
11 years, 5 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari, Evan Stade

CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

When closing the download shelf, hide the buttons of the dangerous download warning. Also fix the shelf closing animation. BUG=13632 TEST=Download an exe (e.g. limewire from downloads.com), so that a "dangerous download" message appears on the shelf. Then close the shelf. The "Yes" and "No" buttons should be hidden, and the whole download shelf should slide down with all items on it in place.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/views/download_shelf_view.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
	M	chrome/browser/views/frame/browser_view.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paul Godavari

LGTM. http://codereview.chromium.org/159261/diff/1/3 File chrome/browser/views/frame/browser_view.cc (right): http://codereview.chromium.org/159261/diff/1/3#newcode1579 Line 1579: || (download_shelf_.get() && download_shelf_->IsClosing())) { Nit: the ...

11 years, 5 months ago (2009-07-23 22:10:35 UTC) #3

Nico

http://codereview.chromium.org/159261/diff/1/3 File chrome/browser/views/frame/browser_view.cc (right): http://codereview.chromium.org/159261/diff/1/3#newcode1579 Line 1579: || (download_shelf_.get() && download_shelf_->IsClosing())) { On 2009/07/23 22:10:35, ...

11 years, 5 months ago (2009-07-24 03:05:28 UTC) #4

Submitted as r21506.

Expand Messages | Collapse Messages