Web Animations: Animate d presentation attribute using InterpolableValue

Web Animations: Animate d property using CSSInterpolationType

CSS Animations and Web Animations use CSSInterpolationType
to animate the d property (used by SVG <path> elements).

There is a slight change in behavior: CSSInterpolationType is
not affected by crbug.com/578727 .

When moveto commands (M or m) appear in a path, they set the
initial point of the current subpath. The next closepath
command (Z or z) resets the current point back to this
initial point.

CSS Transitions still use SVGPathBlender (affected by 578727)
so we currently have a slight difference in behavior.

BUG=535429
Committed: https://crrev.com/ca4dc518e9b940f3e03ea229b69161e578b7c533
Cr-Commit-Position: refs/heads/master@{#370059}

[Eric Willigers, 2016-01-15 04:24:26]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 04:24:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592593002/20001

[Eric Willigers, 2016-01-15 04:24:38]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[Eric Willigers, 2016-01-15 04:28:57]

Patchset #1 (id:1) has been deleted

[Eric Willigers, 2016-01-15 05:10:08]

Description was changed from

==========
Web Animations: Animate d presentation attribute using InterpolableValue

BUG=535429
==========

to

==========
Web Animations: Animate d presentation attribute using InterpolableValue

BUG=535429
==========

[Eric Willigers, 2016-01-15 05:10:30]

Description was changed from

==========
Web Animations: Animate d presentation attribute using InterpolableValue

BUG=535429
==========

to

==========
Web Animations: Animate d property using CSSInterpolationType

BUG=535429
==========

[alancutter (OOO until 2018), 2016-01-15 05:16:44]

Code changes look good though I'm concerned with some of the changes to test
expectations. I think it warrants further investigation.

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation.html
(right):

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation.html:330:
{at: 1.4, is: "path('M 150 160 L 170 190 Z L 88 122 Z M 108 156 L 198 216 Z T
234 220')"}
Why are these values changing?

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
(right):

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp:67:
ASSERT(cssProperty() == CSSPropertyD);
No need to assert this here.

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/PathInterpolation.h (right):

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/PathInterpolation.h:13: class
PathInterpolation {
s/PathInterpolation/PathInterpolationFunctions/ for consistency with other
*InterpolationFunctions utility classes.

[Eric Willigers, 2016-01-18 06:19:54]

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation.html
(right):

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation.html:330:
{at: 1.4, is: "path('M 150 160 L 170 190 Z L 88 122 Z M 108 156 L 198 216 Z T
234 220')"}
On 2016/01/15 05:16:44, alancutter wrote:
> Why are these values changing?

When moveto commands (M or m) appear in the path, the path interpolation
functions consumeSingleCoordinate and consumeInterpolableSingleCoordinate
correctly set the initial point of the current subpath.
The next closepath command (Z or z) resets the current point back to this
initial point.

By contrast, SVGPathBlender (used by Chrome SMIL, and by CSS animations 'd'
before this patch) processes moveto commands in essentially the same way lineto
commands are processed.

Our 'from' value is equivalent to
path('M 10 20 L 30 50 Z L 60 80 Z M 80 100 L 170 160 Z T 150 220')
(using Snap: https://jsfiddle.net/ericwilligers/Laxcwaqh/ )
so in absolute coordinates the last number is 220 for both 'from' and 'to', and
hence also for all offsets.

Created crbug.com/578727

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
(right):

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp:67:
ASSERT(cssProperty() == CSSPropertyD);
On 2016/01/15 05:16:44, alancutter wrote:
> No need to assert this here.

Done.

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/PathInterpolation.h (right):

https://codereview.chromium.org/1592593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/PathInterpolation.h:13: class
PathInterpolation {
On 2016/01/15 05:16:44, alancutter wrote:
> s/PathInterpolation/PathInterpolationFunctions/ for consistency with other
> *InterpolationFunctions utility classes.

Done.

[alancutter (OOO until 2018), 2016-01-18 06:43:41]

lgtm, it's worth adding to the patch description the change in behaviour for CSS
animations.

[Eric Willigers, 2016-01-18 06:57:39]

Description was changed from

==========
Web Animations: Animate d property using CSSInterpolationType

BUG=535429
==========

to

==========
Web Animations: Animate d property using CSSInterpolationType

CSS Animations and Web Animations use CSSInterpolationType
to animate the d property (used by SVG <path> elements).

There is a slight change in behavior: CSSInterpolationType is
not affected by crbug.com/578727 .

When moveto commands (M or m) appear in a path, they set the
initial point of the current subpath. The next closepath
command (Z or z) resets the current point back to this
initial point.

CSS Transitions still use SVGPathBlender (affected by 578727)
so we currently have a slight difference in behavior.

BUG=535429
==========

[Eric Willigers, 2016-01-18 06:57:46]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-01-18 06:57:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592593002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592593002/80001

[commit-bot: I haz the power, 2016-01-18 07:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-18 07:08:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eric Willigers, 2016-01-18 07:52:33]

ericwilligers@chromium.org changed reviewers:
+ fs@opera.com

[Eric Willigers, 2016-01-18 07:53:51]

core.gypi needs owner review

[fs, 2016-01-18 23:34:24]

lgtm

[Eric Willigers, 2016-01-18 23:39:36]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-01-18 23:39:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592593002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592593002/80001

[commit-bot: I haz the power, 2016-01-18 23:44:43]

Description was changed from

==========
Web Animations: Animate d property using CSSInterpolationType

CSS Animations and Web Animations use CSSInterpolationType
to animate the d property (used by SVG <path> elements).

There is a slight change in behavior: CSSInterpolationType is
not affected by crbug.com/578727 .

When moveto commands (M or m) appear in a path, they set the
initial point of the current subpath. The next closepath
command (Z or z) resets the current point back to this
initial point.

CSS Transitions still use SVGPathBlender (affected by 578727)
so we currently have a slight difference in behavior.

BUG=535429
==========

to

==========
Web Animations: Animate d property using CSSInterpolationType

CSS Animations and Web Animations use CSSInterpolationType
to animate the d property (used by SVG <path> elements).

There is a slight change in behavior: CSSInterpolationType is
not affected by crbug.com/578727 .

When moveto commands (M or m) appear in a path, they set the
initial point of the current subpath. The next closepath
command (Z or z) resets the current point back to this
initial point.

CSS Transitions still use SVGPathBlender (affected by 578727)
so we currently have a slight difference in behavior.

BUG=535429
==========

[commit-bot: I haz the power, 2016-01-18 23:44:44]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-01-18 23:46:06]

Description was changed from

==========
Web Animations: Animate d property using CSSInterpolationType

CSS Animations and Web Animations use CSSInterpolationType
to animate the d property (used by SVG <path> elements).

There is a slight change in behavior: CSSInterpolationType is
not affected by crbug.com/578727 .

When moveto commands (M or m) appear in a path, they set the
initial point of the current subpath. The next closepath
command (Z or z) resets the current point back to this
initial point.

CSS Transitions still use SVGPathBlender (affected by 578727)
so we currently have a slight difference in behavior.

BUG=535429
==========

to

==========
Web Animations: Animate d property using CSSInterpolationType

CSS Animations and Web Animations use CSSInterpolationType
to animate the d property (used by SVG <path> elements).

There is a slight change in behavior: CSSInterpolationType is
not affected by crbug.com/578727 .

When moveto commands (M or m) appear in a path, they set the
initial point of the current subpath. The next closepath
command (Z or z) resets the current point back to this
initial point.

CSS Transitions still use SVGPathBlender (affected by 578727)
so we currently have a slight difference in behavior.

BUG=535429

Committed: https://crrev.com/ca4dc518e9b940f3e03ea229b69161e578b7c533
Cr-Commit-Position: refs/heads/master@{#370059}
==========

[commit-bot: I haz the power, 2016-01-18 23:46:07]

Patchset 4 (id:??) landed as
https://crrev.com/ca4dc518e9b940f3e03ea229b69161e578b7c533
Cr-Commit-Position: refs/heads/master@{#370059}