Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 1592573002: Fixing WebViewVisibilityTests for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added Tests and TODO Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | content/browser/frame_host/cross_process_frame_connector.cc » ('j') | content/browser/frame_host/cross_process_frame_connector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/guest_view/browser/guest_view_base.cc
diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc
index 634b1f7900b7eb7b5798e865f6de57b17037a76e..c9725cceda7e839fd9ba22df1ea5092337835db9 100644
--- a/components/guest_view/browser/guest_view_base.cc
+++ b/components/guest_view/browser/guest_view_base.cc
@@ -599,13 +599,6 @@ void GuestViewBase::DidNavigateMainFrame(
const content::FrameNavigateParams& params) {
if (attached() && ZoomPropagatesFromEmbedderToGuest())
SetGuestZoomLevelToMatchEmbedder();
-
- // TODO(lazyboy): This breaks guest visibility in --site-per-process because
- // we do not take the widget's visibility into account. We need to also
- // stay hidden during "visibility:none" state.
- if (content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests()) {
- web_contents()->WasShown();
- }
}
void GuestViewBase::ActivateContents(WebContents* web_contents) {
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | content/browser/frame_host/cross_process_frame_connector.cc » ('j') | content/browser/frame_host/cross_process_frame_connector.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698