content/browser/browser_plugin/browser_plugin_guest.cc - Issue 1592573002: Fixing WebViewVisibilityTests for OOPIF-<webview>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 1592573002: Fixing WebViewVisibilityTests for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: BrowserPluginGuest does not Change Visibility of OOPIF-<webview> Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 983ed41124707e3e1870864c03e51a7eae2e34e6..ed1bdea1f48b0846d1c34d108f1f2453f3010398 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -974,6 +974,10 @@ void BrowserPluginGuest::OnSetEditCommandsForNextKeyEvent(

void BrowserPluginGuest::OnSetVisibility(int browser_plugin_instance_id,

bool visible) {

+ // For OOPIF-<webivew>, the remote frame will handle visibility state.

+ if (BrowserPluginGuestMode::UseCrossProcessFramesForGuests())

+ return;

guest_visible_ = visible;

if (embedder_visible_ && guest_visible_)

GetWebContents()->WasShown();