Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 1592573002: Fixing WebViewVisibilityTests for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/cross_process_frame_connector.cc
diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc
index fef7ff7a621f0f0362efa0d9e2ce52191dee9aff..0f3c832181e959f0a48ef5b28a36a6c02e062964 100644
--- a/content/browser/frame_host/cross_process_frame_connector.cc
+++ b/content/browser/frame_host/cross_process_frame_connector.cc
@@ -233,6 +233,19 @@ void CrossProcessFrameConnector::OnVisibilityChanged(bool visible) {
if (!view_)
return;
+ // If there is an inner WebContents, it should be notified of the change in
+ // the visibility. The Show/Hide methods will not be called if an inner
+ // WebContents exists since the corresponding WebContents will itself call
+ // Show/Hide on all the RenderWidgetHostViews (including this) one.
+ if (frame_proxy_in_parent_renderer_->frame_tree_node()
+ ->render_manager()
+ ->ForInnerDelegate()) {
+ RenderWidgetHostImpl::From(view_->GetRenderWidgetHost())
+ ->delegate()
+ ->OnRenderFrameProxyVisibilityChanged(visible);
+ return;
+ }
+
if (visible)
view_->Show();
else

Powered by Google App Engine
This is Rietveld 408576698