Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2104)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1592573002: Fixing WebViewVisibilityTests for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index f51164ee76a613784e9510a30a57047610f94996..206cd4fbbe6265cb8c9173f5403e867c4ec681f4 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -740,9 +740,9 @@ INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewTest, testing::Bool());
// The following test suits are created to group tests based on specific
// features of <webview>.
-// These features current would not work with
-// --use-cross-process-frames-for-guest and is disabled on
-// UseCrossProcessFramesForGuests.
+// These features currently do not work with
+// --use-cross-process-frames-for-guest and are disabled on
+// kUseCrossProcessFramesForGuests.
class WebViewNewWindowTest : public WebViewTest {};
INSTANTIATE_TEST_CASE_P(WebViewTests,
WebViewNewWindowTest,
@@ -759,7 +759,7 @@ INSTANTIATE_TEST_CASE_P(WebViewTests,
class WebViewVisibilityTest : public WebViewTest {};
INSTANTIATE_TEST_CASE_P(WebViewTests,
WebViewVisibilityTest,
- testing::Values(false));
+ testing::Bool());
class WebViewDPITest : public WebViewTest {
protected:

Powered by Google App Engine
This is Rietveld 408576698