Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1592563002: Don't compile windowed egl into gles2_conform_test_windowless (Closed)

Created:
4 years, 11 months ago by jbauman
Modified:
4 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't compile windowed egl into gles2_conform_test_windowless The symbols from egl_native_win were overriding the windowless symbols, causing it to use a window instead. BUG=none Committed: https://crrev.com/8d82e2ce2bc8d95fbfe53f6e7f98c345bba2de01 Cr-Commit-Position: refs/heads/master@{#371058}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jbauman
4 years, 11 months ago (2016-01-15 20:55:35 UTC) #3
Ken Russell (switch to Gerrit)
Sorry for the long delay reviewing. LGTM
4 years, 11 months ago (2016-01-21 03:25:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592563002/20001
4 years, 11 months ago (2016-01-21 03:30:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/137544)
4 years, 11 months ago (2016-01-21 03:40:03 UTC) #8
jbauman
piman@, OWNERS review.
4 years, 11 months ago (2016-01-22 00:06:46 UTC) #10
piman
lgtm
4 years, 11 months ago (2016-01-22 03:33:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592563002/20001
4 years, 11 months ago (2016-01-22 21:29:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 22:27:54 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 22:28:49 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d82e2ce2bc8d95fbfe53f6e7f98c345bba2de01
Cr-Commit-Position: refs/heads/master@{#371058}

Powered by Google App Engine
This is Rietveld 408576698