Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2511)

Unified Diff: chrome/browser/gtk/bookmark_bar_gtk.cc

Issue 159256: Bookmark bar: Don't connect to the OnDragDrop signal since we can just use th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/bookmark_bar_gtk.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_bar_gtk.cc
===================================================================
--- chrome/browser/gtk/bookmark_bar_gtk.cc (revision 21363)
+++ chrome/browser/gtk/bookmark_bar_gtk.cc (working copy)
@@ -165,8 +165,6 @@
G_CALLBACK(&OnToolbarDragMotion), this);
g_signal_connect(bookmark_toolbar_.get(), "drag-leave",
G_CALLBACK(&OnToolbarDragLeave), this);
- g_signal_connect(bookmark_toolbar_.get(), "drag-drop",
- G_CALLBACK(&OnToolbarDragDrop), this);
g_signal_connect(bookmark_toolbar_.get(), "drag-data-received",
G_CALLBACK(&OnToolbarDragReceived), this);
g_signal_connect(bookmark_toolbar_.get(), "button-press-event",
@@ -772,25 +770,6 @@
}
// static
-gboolean BookmarkBarGtk::OnToolbarDragDrop(
- GtkWidget* widget, GdkDragContext* context,
- gint x, gint y, guint time,
- BookmarkBarGtk* bar) {
- gboolean is_valid_drop_site = FALSE;
-
- if (context->targets) {
- GdkAtom target_type =
- GDK_POINTER_TO_ATOM(g_list_nth_data(
- context->targets, GtkDndUtil::CHROME_BOOKMARK_ITEM));
- gtk_drag_get_data(widget, context, target_type, time);
-
- is_valid_drop_site = TRUE;
- }
-
- return is_valid_drop_site;
-}
-
-// static
void BookmarkBarGtk::OnToolbarDragReceived(GtkWidget* widget,
GdkDragContext* context,
gint x, gint y,
« no previous file with comments | « chrome/browser/gtk/bookmark_bar_gtk.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698