Fix a race condition where rapid back/forward clicks could close a tab...

chrome/common/render_messages_internal.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This header is meant to be included in multiple passes, hence no traditional
 // header guard.
 // See ipc_message_macros.h for explanation of the macros and passes.
 
 #include <string>
 #include <vector>
@@ skipping 441 matching lines @@
   // the browser has the option of sending a ViewMsg_CantFocus back to
   // the renderer.
   IPC_MESSAGE_ROUTED0(ViewMsg_CantFocus)
 
   // Instructs the renderer to invoke the frame's shouldClose method, which
   // runs the onbeforeunload event handler.  Expects the result to be returned
   // via ViewHostMsg_ShouldClose.
   IPC_MESSAGE_ROUTED0(ViewMsg_ShouldClose)
 
   // Instructs the renderer to close the current page, including running the
-  // onunload event handler.  Expects a ClosePage_ACK message when finished.
-  IPC_MESSAGE_ROUTED2(ViewMsg_ClosePage,
-                      int /* new_render_process_host_id */,
-                      int /* new_request_id */)
+  // onunload event handler. See the struct in render_messages.h for more.
+  //
+  // Expects a ClosePage_ACK message when finished, where the parameters are
+  // echoed back.
+  IPC_MESSAGE_ROUTED1(ViewMsg_ClosePage,
+                      ViewMsg_ClosePage_Params)
 
   // Asks the renderer to send back stats on the WebCore cache broken down by
   // resource types.
   IPC_MESSAGE_CONTROL0(ViewMsg_GetCacheResourceStats)
 
   // Asks the renderer to send back Histograms.
   IPC_MESSAGE_CONTROL1(ViewMsg_GetRendererHistograms,
                        int /* sequence number of Renderer Histograms. */)
 
   // Notifies the renderer about ui theme changes
@@ skipping 732 matching lines @@
                       webkit_glue::WebApplicationInfo)
 
   // Provides the result from running OnMsgShouldClose.  |proceed| matches the
   // return value of the the frame's shouldClose method (which includes the
   // onbeforeunload handler): true if the user decided to proceed with leaving
   // the page.
   IPC_MESSAGE_ROUTED1(ViewHostMsg_ShouldClose_ACK,
                       bool /* proceed */)
 
   // Indicates that the current page has been closed, after a ClosePage
-  // message.
-  IPC_MESSAGE_ROUTED2(ViewHostMsg_ClosePage_ACK,
-                      int /* new_render_process_host_id */,
-                      int /* new_request_id */)
+  // message. The parameters are just echoed from the ClosePage request.
+  IPC_MESSAGE_ROUTED1(ViewHostMsg_ClosePage_ACK,
+                      ViewMsg_ClosePage_Params)
 
   IPC_MESSAGE_ROUTED4(ViewHostMsg_DidDownloadFavIcon,
                       int /* Identifier of the request */,
                       GURL /* URL of the image */,
                       bool /* true if there was a network error */,
                       SkBitmap /* image_data */)
 
   // Sent to query MIME information.
   IPC_SYNC_MESSAGE_CONTROL1_1(ViewHostMsg_GetMimeTypeFromExtension,
                               FilePath::StringType /* extension */,
@@ skipping 342 matching lines @@
   // web resource.  |error_message| is a user-readable explanation of what
   // went wrong.
   IPC_MESSAGE_CONTROL1(UtilityHostMsg_UnpackWebResource_Failed,
                        std::string /* error_message, if any */)
 
   // Sent by the renderer process to acknowledge receipt of a
   // ViewMsg_CSSInsertRequest message and css has been inserted into the frame.
   IPC_MESSAGE_ROUTED0(ViewHostMsg_OnCSSInserted)
 
 IPC_END_MESSAGES(ViewHost)