Fix a race condition where rapid back/forward clicks could close a tab...

Fix a race condition where rapid back/forward clicks could close a tab

This can be triggered when you're on the new tab page, going to *two* other
sites, then rapidly hitting back and forward randomly. If a cross-site
transition was canceled before the original page responds with an "OK to close
me" message, it will mistakenly categorize the close as not just for the
RenderView (correspondong to one side of the cross-site transition) but for the
entire tab.

This change adds an explicit parameter on the messages indicating whether it's
for interstials or for the tab so we don't have to rely on the request still
being active.

This also adds the "requesting process + route" in addition to the
"new process + request" so we can be more clear about sending the messages to
the correct place. The previous patch conbimed these in a confusing way.

BUG=16246
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21531

[brettw, 2009-07-23 14:52:00]

I spent a while trying to write a test for this. I was hoping to be able to send
a message to the first renderer to cause it to pause so I can replicate the
race. However, the pause must be from within the close request of the first
page, which would be nasty to hack in support for. Hopefully the more explicit
parameters in the new message will be good enough.

[jam, 2009-07-23 20:22:22]

lgtm

[darin (slow to review), 2009-07-23 20:39:49]

LGTM

http://codereview.chromium.org/159255/diff/27/2005
File chrome/browser/renderer_host/render_process_host.h (right):

http://codereview.chromium.org/159255/diff/27/2005#newcode121
Line 121: virtual void CrossSiteClosePageACK(int closing_process_id,
i wonder if we shouldn't have a structure for these parameters.

http://codereview.chromium.org/159255/diff/27/2008
File chrome/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/159255/diff/27/2008#newcode190
Line 190: 
gratuitous new lines?

[brettw, 2009-07-23 23:20:05]

New snap up with structure usage (if you care). Currently waiting for trybots.

[darin (slow to review), 2009-07-23 23:22:22]

Nice, I like how this cleans things up.