Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1592513002:
Use a predicate that isn't so granular during continuous read. (Closed)
|
Created:
4 years, 11 months ago by David Tseng Modified:
4 years, 11 months ago Reviewers:
dmazzoni CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse a predicate that isn't so granular during continuous read.
Currently, continuous read uses the Node predicate. We want to use the DOM_NODE predicate because it doesn't chunk up nodes quite as much. This results in smoother reading (e.g. not breaking apart between lines).much.
Committed: https://crrev.com/144ff1bd87065415f6125086ba1c2762ba5d7d00
Cr-Commit-Position: refs/heads/master@{#370784}
Patch Set 1 #
Total comments: 1
Patch Set 2 : #Patch Set 3 : #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Use a predicate that isn't so granular during continuous read. ========== to ========== Use a predicate that isn't so granular during continuous read. Currently, continuous read uses the Node predicate. We want to use the DOM_NODE predicate because it doesn't chunk up nodes quite as much. This results in smoother reading (e.g. not breaking apart between lines).much. ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
lgtm, but please revert everything other than the change to background.js before committing https://codereview.chromium.org/1592513002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/chromevox/chromevox/injected/init_document.js (left): https://codereview.chromium.org/1592513002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/chromevox/chromevox/injected/init_document.js:54: cvox.ChromeVox.isClassicEnabled_ = window.top == window ? undefined : true; Is this from a different patch?
lgtm
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592513002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by dtseng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/1592513002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592513002/40001
Message was sent while issue was closed.
Description was changed from ========== Use a predicate that isn't so granular during continuous read. Currently, continuous read uses the Node predicate. We want to use the DOM_NODE predicate because it doesn't chunk up nodes quite as much. This results in smoother reading (e.g. not breaking apart between lines).much. ========== to ========== Use a predicate that isn't so granular during continuous read. Currently, continuous read uses the Node predicate. We want to use the DOM_NODE predicate because it doesn't chunk up nodes quite as much. This results in smoother reading (e.g. not breaking apart between lines).much. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use a predicate that isn't so granular during continuous read. Currently, continuous read uses the Node predicate. We want to use the DOM_NODE predicate because it doesn't chunk up nodes quite as much. This results in smoother reading (e.g. not breaking apart between lines).much. ========== to ========== Use a predicate that isn't so granular during continuous read. Currently, continuous read uses the Node predicate. We want to use the DOM_NODE predicate because it doesn't chunk up nodes quite as much. This results in smoother reading (e.g. not breaking apart between lines).much. Committed: https://crrev.com/144ff1bd87065415f6125086ba1c2762ba5d7d00 Cr-Commit-Position: refs/heads/master@{#370784} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/144ff1bd87065415f6125086ba1c2762ba5d7d00 Cr-Commit-Position: refs/heads/master@{#370784} |
