Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: tools/valgrind/possible.patch

Issue 159251: Add new option --show-possible to valgrind for later use by valgrind_test.py ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/valgrind/build-valgrind-for-chromium.sh ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 Index: memcheck/mc_main.c
2 ===================================================================
3 --- memcheck/mc_main.c (revision 10536)
4 +++ memcheck/mc_main.c (working copy)
5 @@ -4658,6 +4658,7 @@
6 LeakCheckMode MC_(clo_leak_check) = LC_Summary;
7 VgRes MC_(clo_leak_resolution) = Vg_HighRes;
8 Bool MC_(clo_show_reachable) = False;
9 +Bool MC_(clo_show_possible) = True;
10 Bool MC_(clo_workaround_gcc296_bugs) = False;
11 Int MC_(clo_malloc_fill) = -1;
12 Int MC_(clo_free_fill) = -1;
13 @@ -4711,6 +4712,7 @@
14
15 if VG_BOOL_CLO(arg, "--partial-loads-ok", MC_(clo_partial_loads_ok)) {}
16 else if VG_BOOL_CLO(arg, "--show-reachable", MC_(clo_show_reachable)) {}
17 + else if VG_BOOL_CLO(arg, "--show-possible", MC_(clo_show_possible)) {}
18 else if VG_BOOL_CLO(arg, "--workaround-gcc296-bugs",
19 MC_(clo_workaround_gcc296_bugs)) {}
20
21 @@ -4776,6 +4778,7 @@
22 " --leak-check=no|summary|full search for memory leaks at exit? [summar y]\n"
23 " --leak-resolution=low|med|high differentiation of leak stack traces [hig h]\n"
24 " --show-reachable=no|yes show reachable blocks in leak check? [no] \n"
25 +" --show-possible=no|yes show possibly lost blocks in leak check? [yes]\n"
26 " --undef-value-errors=no|yes check for undefined value errors [yes]\n"
27 " --track-origins=no|yes show origins of undefined values? [no]\n"
28 " --partial-loads-ok=no|yes too hard to explain here; see manual [no] \n"
29 Index: memcheck/mc_include.h
30 ===================================================================
31 --- memcheck/mc_include.h (revision 10536)
32 +++ memcheck/mc_include.h (working copy)
33 @@ -390,6 +390,9 @@
34 /* In leak check, show reachable-but-not-freed blocks? default: NO */
35 extern Bool MC_(clo_show_reachable);
36
37 +/* In leak check, show possibly-lost blocks? default: YES */
38 +extern Bool MC_(clo_show_possible);
39 +
40 /* Assume accesses immediately below %esp are due to gcc-2.96 bugs.
41 * default: NO */
42 extern Bool MC_(clo_workaround_gcc296_bugs);
43 Index: memcheck/mc_leakcheck.c
44 ===================================================================
45 --- memcheck/mc_leakcheck.c (revision 10536)
46 +++ memcheck/mc_leakcheck.c (working copy)
47 @@ -844,7 +844,8 @@
48 print_record = is_full_check &&
49 ( MC_(clo_show_reachable) ||
50 Unreached == lr->key.state ||
51 - Possible == lr->key.state );
52 + ( MC_(clo_show_possible) &&
53 + Possible == lr->key.state ) );
54 is_suppressed =
55 MC_(record_leak_error) ( tid, i+1, n_lossrecords, lr, print_record );
56
OLDNEW
« no previous file with comments | « tools/valgrind/build-valgrind-for-chromium.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698