Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 159251: Add new option --show-possible to valgrind for later use by valgrind_test.py ... (Closed)

Created:
11 years, 5 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, stuartmorgan
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, stuartmorgan, dank, the_wrong_timurrrr, Nirnimesh
Visibility:
Public.

Description

Add new option --show-possible to valgrind for later use by valgrind_test.py to speed up log processing. BUG=17484 TEST=run to install new valgrind; sh tools/valgrind/chrome_tests.sh -t base --tool_flags="--nocleanup_on_exit --show-possible=no"; grep PossiblyLost valgrind.tmp/* should find no matches. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M tools/valgrind/build-valgrind-for-chromium.sh View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/valgrind/possible.patch View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dank
Step 1 in a plan to help speed up the ui test bots. Step 2 ...
11 years, 5 months ago (2009-07-23 00:50:23 UTC) #1
Lei Zhang
11 years, 5 months ago (2009-07-23 01:27:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698