LayoutTests/compositing/contents-opaque/visibility-hidden-expected.txt - Issue 15925012: Merges two WK fixes for RenderLayer::backgroundIsKnownToBeOpaque.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/compositing/contents-opaque/visibility-hidden-expected.txt

Issue 15925012: Merges two WK fixes for RenderLayer::backgroundIsKnownToBeOpaque. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: added DOCTYPE Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/compositing/contents-opaque/hidden-with-visible-text-expected.txt ('K') | « LayoutTests/compositing/contents-opaque/visibility-hidden.html ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 (GraphicsLayer	1 (GraphicsLayer

2 (bounds 800.00 600.00)	2 (bounds 800.00 600.00)

3 (children 1	3 (children 1

4 (GraphicsLayer	4 (GraphicsLayer

5 (bounds 800.00 600.00)	5 (bounds 800.00 600.00)

6 (contentsOpaque 1)	6 (contentsOpaque 1)

7 (drawsContent 1)	7 (drawsContent 1)

8 (children 1	8 (children 1

9 (GraphicsLayer	9 (GraphicsLayer

10 (position 8.00 8.00)	10 (position 8.00 20.00)

11 (bounds 100.00 100.00)	11 (bounds 200.00 50.00)

12 (contentsOpaque 1)

13 (drawsContent 1)	12 (drawsContent 1)

14 (backgroundColor #C0C0C0)	13 (backgroundColor #C0C0C0)
	Xianzhu 2015/05/07 15:51:05 alokp@ this looks incorrect to me. The object has alokp@ this looks incorrect to me. The object has been set 'visibility: hidden', why there is still a layer with background color? alokp 2015/05/07 17:00:59 May be assumptions have changed in 2 years since t Show quoted text On 2015/05/07 15:51:05, Xianzhu wrote: > alokp@ this looks incorrect to me. The object has been set 'visibility: hidden', > why there is still a layer with background color? May be assumptions have changed in 2 years since this patch landed. What are you asking? - Why is there even a layer for invisible element, or - Why does this layer have a background color? The important thing that this patch was trying to accomplish is to make sure we do not mark layers as opaque when they are NOT. We were trying to be conservative about it. Xianzhu 2015/05/07 17:13:24 I'm asking mainly the first question. Will content Show quoted text On 2015/05/07 17:00:59, Alok Priyadarshi wrote: > On 2015/05/07 15:51:05, Xianzhu wrote: > > alokp@ this looks incorrect to me. The object has been set 'visibility: > hidden', > > why there is still a layer with background color? > > May be assumptions have changed in 2 years since this patch landed. > > What are you asking? > - Why is there even a layer for invisible element, or > - Why does this layer have a background color? > > The important thing that this patch was trying to accomplish is to make sure we > do not mark layers as opaque when they are NOT. We were trying to be > conservative about it. I'm asking mainly the first question. Will contentsOpaque affect whether cc to display the layer?
15 )	14 )

16 )	15 )

17 )	16 )

18 )	17 )

19 )	18 )

20	19

OLD	NEW