Virtual context MakeCurrent tweaks.

gpu/command_buffer/service/gl_context_virtual.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gl_context_virtual.h"
 
 #include "gpu/command_buffer/service/gl_state_restorer_impl.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 #include "ui/gl/gl_surface.h"
 
@@ skipping 36 matching lines @@
   return true;
 }
 
 void GLContextVirtual::Destroy() {
   shared_context_->OnDestroyVirtualContext(this);
   shared_context_ = NULL;
   display_ = NULL;
 }
 
 bool GLContextVirtual::MakeCurrent(gfx::GLSurface* surface) {
-  // TODO(epenner): We should avoid bypassing MakeVirtuallyCurrent() below
-  // (return false or DCHECK when !decoder). To do this we must reorder
-  // tear-down in GpuCommandBufferStub::Destroy().
   if (decoder_.get())
-    shared_context_->MakeVirtuallyCurrent(this, surface);
-  else if (!IsCurrent(surface))
-    shared_context_->MakeCurrent(surface);
-  return true;
+    return shared_context_->MakeVirtuallyCurrent(this, surface);
+
+  LOG(ERROR) << "Trying to make virtual context current without decoder.";

[epenner, 2013/05/28 22:57:21]

Me like.

+  return false;
 }
 
 void GLContextVirtual::ReleaseCurrent(gfx::GLSurface* surface) {
-  if (IsCurrent(surface))
-    shared_context_->ReleaseCurrent(surface);
+  shared_context_->ReleaseCurrent(surface);
 }
 
 bool GLContextVirtual::IsCurrent(gfx::GLSurface* surface) {
   // If it's a real surface it needs to be current.
   if (surface &&
       !surface->GetBackingFrameBufferObject() &&
       !surface->IsOffscreen())
     return shared_context_->IsCurrent(surface);
 
   // Otherwise, only insure the context itself is current.
@@ skipping 29 matching lines @@
 
 void GLContextVirtual::SetUnbindFboOnMakeCurrent() {
   shared_context_->SetUnbindFboOnMakeCurrent();
 }
 
 GLContextVirtual::~GLContextVirtual() {
   Destroy();
 }
 
 }  // namespace gpu