third_party/WebKit/Source/core/paint/InlinePainter.cpp - Issue 1592493002: Fix links in inline continuations in printed PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlinePainter.cpp

Issue 1592493002: Fix links in inline continuations in printed PDF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/InlinePainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlinePainter.cpp b/third_party/WebKit/Source/core/paint/InlinePainter.cpp

index 70adeb57948d4dc943630f6ab1926665789686fd..c3e9cfa0009641e9acec169a05e1456f1019e214 100644

--- a/third_party/WebKit/Source/core/paint/InlinePainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlinePainter.cpp

@@ -31,8 +31,6 @@ void InlinePainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOf

m_layoutInline.mutableForPainting().setPreviousPaintOffset(paintOffset);

}

- // FIXME: When Skia supports annotation rect covering (https://code.google.com/p/skia/issues/detail?id=3872),

- // this rect may be covered by foreground and descendant drawings. Then we may need a dedicated paint phase.

if (paintInfo.phase == PaintPhaseForeground && paintInfo.isPrinting())

ObjectPainter(m_layoutInline).addPDFURLRectIfNeeded(paintInfo, paintOffset);