Merged PipelineInternal into PipelineImpl, eliminating a ton of thread-UNsafeness and confusion.

Merged PipelineInternal into PipelineImpl, eliminating a ton of thread-UNsafeness and confusion.

Long story short: there's no reason to split an implementation of class between two classes.  The data was being held in one class, with the other class accessing it privately without acquiring the lock.  Really, really painful to debug as well.

Now we have a unified implementation of Pipeline that takes care of client API requests as well as filter interaction.

Since Pipeline is properly reference counted and there are two less objects to worry about, the crash reported in 3.0.195.1 should also be resolved.

BUG=17107, 17548
TEST=pipeline tests, media player and chrome ui tests

[scherkus (not reviewing), 2009-07-23 00:13:30]

phew... pretty straight forward review (I think)

passes unit tests, a quick'n'dirty media player test, and valgrind test on linux

more CLs follow this one but those are for later

[Alpha Left Google, 2009-07-23 00:32:06]

So PipelineImpl is not refcounted? I see it inherits FileterHost and Pipeline,
which one is refcounted?

[Alpha Left Google, 2009-07-23 00:34:04]

On 2009/07/23 00:32:06, Alpha wrote:
> So PipelineImpl is not refcounted? I see it inherits FileterHost and Pipeline,
> which one is refcounted?

Just to be safe, you can run MediaLeakTest.* on test_shell_tests, that way you
can make sure everything is still intact.

If those are all good, then LGTM! Finally can get rid of 3 different classes!

[scherkus (not reviewing), 2009-07-23 20:09:18]

Pipeline (the interface) is now a ref counted interface:
http://codereview.chromium.org/155713

On Wed, Jul 22, 2009 at 5:34 PM, <hclam@chromium.org> wrote:

> On 2009/07/23 00:32:06, Alpha wrote:
>
>> So PipelineImpl is not refcounted? I see it inherits FileterHost and
>>
> Pipeline,
>
>> which one is refcounted?
>>
>
> Just to be safe, you can run MediaLeakTest.* on test_shell_tests, that
> way you can make sure everything is still intact.
>
> If those are all good, then LGTM! Finally can get rid of 3 different
> classes!
>
>
> http://codereview.chromium.org/159246
>

[Alpha Left Google, 2009-07-23 20:10:31]

OK! LGTM.