Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: src/hydrogen.cc

Issue 159233002: A64: Remove restriction for inlining functions now that the allocator can handle cp (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index b4bca14e494709451a485f06ca62103fbaabb224..b72a743a4b5819a7063640eb35240d08779e8d87 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -7066,19 +7066,6 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
return false;
}
-#if V8_TARGET_ARCH_A64
- // Target must be able to use caller's context.
- // TODO(jochen): Remove this block once A64's register allocator can allocate
- // cp.
- CompilationInfo* outer_info = current_info();
- if (target->context() != outer_info->closure()->context() ||
- outer_info->scope()->contains_with() ||
- outer_info->scope()->num_heap_slots() > 0) {
- TraceInline(target, caller, "target requires context change");
- return false;
- }
-#endif
-
// Don't inline deeper than the maximum number of inlining levels.
HEnvironment* env = environment();
int current_level = 1;
@@ -7215,12 +7202,8 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
undefined,
function_state()->inlining_kind());
-// TODO(jochen): Remove this #ifdef once A64's register allocator can allocate
-// cp.
-#if !V8_TARGET_ARCH_A64
HConstant* context = Add<HConstant>(Handle<Context>(target->context()));
inner_env->BindContext(context);
-#endif
Add<HSimulate>(return_id);
current_block()->UpdateEnvironment(inner_env);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698