WebCorePrefix.h is only used for Mac OS X. Clean up dead code and remove including wtf/Platform.h.

WebCorePrefix.h is only used for Mac OS X. Clean up dead code and remove including wtf/Platform.h.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151165

[lgombos, 2013-05-26 19:00:56]

2 motivations for this CL:
 - Remove dead code
 - Long term remove wtf/Platform.h

[abarth-chromium, 2013-05-26 19:10:15]

LGTM

Should we rename it something obviously mac-specific?  Should we remove it and
just add the needed includes where they're needed?

[abarth-chromium, 2013-05-26 19:11:05]

https://codereview.chromium.org/15923004/diff/3001/Source/core/WebCorePrefix.h
File Source/core/WebCorePrefix.h (right):

https://codereview.chromium.org/15923004/diff/3001/Source/core/WebCorePrefix....
Source/core/WebCorePrefix.h:22: *    1) files to precompile for faster builds
Does it actually make the build faster?

[lgombos, 2013-05-26 21:50:36]

> Does it actually make the build faster?

According to a comment in core.gyp "Some Mac-specific parts of WebKit won't
compile without having WebCorePrefix precompiled. I think we should investigate
in a separate CL what would it take to build for MacOS without the precompiled
header and compare the build time between the 2 options.

[lgombos, 2013-05-26 21:52:16]

On 2013/05/26 19:10:15, abarth wrote:
> LGTM
> 
> Should we rename it something obviously mac-specific? 

I'll rename it to WebCoreFrefixMac and will land. We should continue to
investigate if pre-compilation is necessary or if it improves build time.

[abarth-chromium, 2013-05-26 22:07:52]

On 2013/05/26 21:50:36, lgombos wrote:
> > Does it actually make the build faster?
> 
> According to a comment in core.gyp "Some Mac-specific parts of WebKit won't
> compile without having WebCorePrefix precompiled. I think we should
investigate
> in a separate CL what would it take to build for MacOS without the precompiled
> header and compare the build time between the 2 options.

Yeah, presumably we can fix those compilation problems, if they still exist.

[commit-bot: I haz the power, 2013-05-26 22:34:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/15923004/9001

[commit-bot: I haz the power, 2013-05-26 23:26:34]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-27 01:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/15923004/9001

[commit-bot: I haz the power, 2013-05-27 02:06:51]

Change committed as 151165