Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15923002: Move CSSOM classes to using MutableStylePropertySet over StylePropertySet. (Closed)

Created:
7 years, 7 months ago by darktears
Modified:
7 years, 7 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Move CSSOM classes to using MutableStylePropertySet over StylePropertySet. Moved ensureCSSStyleDeclaration() and ensureInlineCSSStyleDeclaration() from StylePropertySet to MutableStylePropertySet. StyleRule & co now return a MutableStylePropertySet* from mutableProperties() to aid with... CSSStyleDeclaration now only deals with MutableStylePropertySets. This was already the case in practice, we just didn't have any compile-time foot-shooting protection. In other words, if there's a CSSOM wrapper for a given StylePropertySet, it's guaranteed to be mutable, and the pointer types now reflect this. This is a backport from WebKit r148396. Patch by Andreas Kling reviewed by Anders Carlsson. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -54 lines) Patch
M Source/core/css/PropertySetCSSStyleDeclaration.h View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M Source/core/css/StyleRule.h View 7 chunks +7 lines, -6 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/WebKitCSSKeyframeRule.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/WebKitCSSKeyframeRule.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Attr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
darktears
7 years, 7 months ago (2013-05-23 19:39:23 UTC) #1
eseidel
lgtm I'd like to see all the CSSOM classes moved into a separate directory so ...
7 years, 7 months ago (2013-05-23 20:35:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15923002/1
7 years, 7 months ago (2013-05-23 20:36:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_lint, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9711
7 years, 7 months ago (2013-05-23 21:46:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15923002/1
7 years, 7 months ago (2013-05-23 21:53:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7115
7 years, 7 months ago (2013-05-23 23:24:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15923002/1
7 years, 7 months ago (2013-05-24 00:01:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7163
7 years, 7 months ago (2013-05-24 01:17:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15923002/1
7 years, 7 months ago (2013-05-24 01:49:35 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7207
7 years, 7 months ago (2013-05-24 03:07:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15923002/1
7 years, 7 months ago (2013-05-24 09:51:00 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7314
7 years, 7 months ago (2013-05-24 11:25:52 UTC) #12
darktears
7 years, 7 months ago (2013-05-24 11:41:13 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 manually as r151073.

Powered by Google App Engine
This is Rietveld 408576698