Issue 159216: Linux: add support for tm_zone to localtime via the sandbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159216: Linux: add support for tm_zone to localtime via the sandbox. (Closed)

Created:
11 years, 5 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: add support for tm_zone to localtime via the sandbox. Glibc adds a field to struct tm, tm_zone, which contains a pointer to a string for the current time zone. Since this makes struct tm a non-POD data type, it only works for the non-thread-safe localtime() call, not localtime_r(). However, V8 relies on it so this patch adds support for passing it through our sandbox. BUG=17458

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -8 lines)			Patch
	M	chrome/browser/renderer_host/render_sandbox_host_linux.cc	View		1 chunk	+6 lines, -4 lines	1 comment	Download
	M	chrome/browser/zygote_main_linux.cc	View		2 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 5 months ago (2009-07-22 20:01:41 UTC) #2

LGTM

http://codereview.chromium.org/159216/diff/1/2
File chrome/browser/renderer_host/render_sandbox_host_linux.cc (right):

http://codereview.chromium.org/159216/diff/1/2#newcode303
Line 303: const std::string result_string(reinterpret_cast<const
char*>(expanded_time),
Nit: 80 cols.

Expand Messages | Collapse Messages