Return Error Status Upon Blocking Requests...

Return Error Status Upon Blocking Requests

Blocked requests now return an error status so that the Chrome throbber does
not spin indefinitely when blocking URL requests.

This code shall be replaced with resource substitution next but gives a better
experience until then. Same goes for the added type-based interception.

TEST=none
BUG=16932
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21536

[idanan, 2009-07-23 20:05:08]

Hi Brett,

Here is some temporary code for blacklisted requests to return a failure status
instead of letting Chrome spin indefinitely. As the TODOs say, this will later
be replaced by actual responses.

[brettw, 2009-07-23 23:53:42]

http://codereview.chromium.org/159214/diff/5/6
File chrome/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/159214/diff/5/6#newcode367
Line 367: // TODO(idanan): Send a ResourceResponse to replace the blocked
resource.
Can you update this comment to say that the proposed behavior is instead of the
current "RequestComplete" sending.

http://codereview.chromium.org/159214/diff/5/6#newcode378
Line 378: route_id,
These should be indented 4 spaces instead of 2.

http://codereview.chromium.org/159214/diff/5/6#newcode1029
Line 1029: request->GetUserData((void*)&Blacklist::kRequestDataKey);
Don't use C-style casts. I think you can static_cast to void*.

http://codereview.chromium.org/159214/diff/5/6#newcode1032
Line 1032: if (match->attributes() & Blacklist::kBlockByType)
We require {} for multi-line blocks.

[idanan, 2009-07-24 15:19:47]

All done.

Regarding the (void*) cast, the issue was constness of the key parameter in
URLRequest, so I changed it there in URLRequest.{h,cc} to get rid of it
properly. So you get a few more files for the update patch.

[idanan, 2009-07-24 15:33:03]

Sorry for the previous patch had a typo as I saved. This one compiles!

[brettw, 2009-07-24 15:52:06]

LGTM