Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: content/renderer/gpu/input_handler_manager_client.h

Issue 15920002: Fix WebView compositor input handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/input_handler_manager_client.h
diff --git a/content/renderer/gpu/input_handler_manager_client.h b/content/renderer/gpu/input_handler_manager_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..6152eb6e416342280a7f7cb154fdc920e5937d71
--- /dev/null
+++ b/content/renderer/gpu/input_handler_manager_client.h
@@ -0,0 +1,48 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_GPU_INPUT_HANDLER_MANAGER_CLIENT_H_
+#define CONTENT_RENDERER_GPU_INPUT_HANDLER_MANAGER_CLIENT_H_
+
+#include "base/basictypes.h"
+#include "base/callback_forward.h"
+
+namespace WebKit {
+class WebInputEvent;
+}
+
+namespace content {
+
+class InputHandlerManagerClient {
+ public:
+ virtual ~InputHandlerManagerClient() {}
+
+ // The Handler allows the client to forward input events in such a way that
+ // callbacks to DidHandleInputEvent or DidNotHandlerInputEvent are made with
+ // the appropriate response.
+ // The Manager will supply a valid |handler| when bound to the client,
+ // valid until the manager shuts down, when it supplies an empty |handler|.
+ // The client should only makes calls to |handler| on the compositing thread.
+ typedef base::Callback<void(int /*routing_id*/,
jamesr 2013/06/04 06:51:11 i think using a return value here instead of Did(N
jdduke (slow) 2013/06/04 15:46:23 Yeah, just rebased with the new patch that does ju
+ const WebKit::WebInputEvent*)> Handler;
+
+ // Called from the main thread.
+ virtual void SetHandler(const Handler& handler) = 0;
+ virtual void DidAddInputHandler(int routing_id) = 0;
+ virtual void DidRemoveInputHandler(int routing_id) = 0;
+
+ // Called from the compositing thread.
+ virtual void DidHandleInputEvent() = 0;
+ virtual void DidNotHandleInputEvent(bool send_to_widget) = 0;
+
+ protected:
+ InputHandlerManagerClient() {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(InputHandlerManagerClient);
+};
+
+} // namespace content
+
+#endif // CONTENT_COMMON_GPU_INPUT_HANDLER_MANAGER_CLIENT_H_

Powered by Google App Engine
This is Rietveld 408576698