Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 15920002: Fix WebView compositor input handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 386e4426cf74d02af2eefafd38f4f9c4c31755fc..2c79c84c7a53a344987ea4540608a8e9d4a2ac2f 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -57,6 +57,7 @@
#include "content/renderer/gpu/compositor_output_surface.h"
#include "content/renderer/gpu/gpu_benchmarking_extension.h"
#include "content/renderer/gpu/input_handler_manager.h"
+#include "content/renderer/gpu/input_event_filter.h"
#include "content/renderer/media/audio_input_message_filter.h"
#include "content/renderer/media/audio_message_filter.h"
#include "content/renderer/media/audio_renderer_mixer_manager.h"
@@ -461,9 +462,10 @@ void RenderThreadImpl::Shutdown() {
}
compositor_thread_.reset();
- if (input_handler_manager_) {
- RemoveFilter(input_handler_manager_->GetMessageFilter());
- input_handler_manager_.reset();
+ input_handler_manager_.reset();
+ if (input_event_filter_) {
+ RemoveFilter(input_event_filter_.get());
+ input_event_filter_ = NULL;
}
if (webkit_platform_support_)
@@ -768,9 +770,21 @@ void RenderThreadImpl::EnsureWebKitInitialized() {
false));
}
+ InputHandlerManagerClient* input_handler_manager_client = NULL;
+#if defined(OS_ANDROID)
+ if (SynchronousCompositorFactory* factory =
+ SynchronousCompositorFactory::GetInstance()) {
+ input_handler_manager_client = factory->GetInputHandlerManagerClient();
+ }
+#endif
+ if (!input_handler_manager_client) {
+ input_event_filter_ =
+ new InputEventFilter(this, compositor_message_loop_proxy_);
+ input_handler_manager_client = input_event_filter_.get();
+ }
input_handler_manager_.reset(
- new InputHandlerManager(this, compositor_message_loop_proxy_));
- AddFilter(input_handler_manager_->GetMessageFilter());
+ new InputHandlerManager(compositor_message_loop_proxy_));
+ input_handler_manager_->BindToClient(input_handler_manager_client);
}
scoped_refptr<base::MessageLoopProxy> output_surface_loop;
« content/renderer/gpu/input_handler_manager_client.h ('K') | « content/renderer/render_thread_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698