Issue 159193: Removes the frames/borders in the Mac find bar. Uses find_next and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159193: Removes the frames/borders in the Mac find bar. Uses find_next and (Closed)

Created:
11 years, 5 months ago by Abhi

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Removes the frames/borders in the Mac find bar. Uses find_next and find_prev as the basis for the next and previous buttons. BUG=14904

Patch Set 1 #

Patch Set 2 : Just changed the close bar as waiting for new graphics for find_next and find_prev #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -5 lines)			Patch
	M	chrome/app/nibs/FindBar.xib	View	1	5 chunks	+24 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 5 months ago (2009-07-22 16:23:52 UTC) #2

I like the change to use close_bar and close_bar_p, but I don't think the
find_next and find_prev artwork works well here.  The buttons aren't the same
height as the textfield, and they have a slight bluish tint that works well on
windows but not as well here.

Can you rework this patch to have only the close button changes?  I'll send out
an email asking for new artwork for the other buttons.

Expand Messages | Collapse Messages