Gtk cookie manager part 1....

Gtk cookie manager part 1.

(Doesn't display cookie details, otherwise working.)

BUG=11507
TEST=All cookie manager functions should work as expected, other than viewing the cookie details.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21307

[Evan Stade, 2009-07-22 03:36:32]

lgtm

http://codereview.chromium.org/159187/diff/1005/1007
File chrome/browser/gtk/options/advanced_contents_gtk.cc (right):

http://codereview.chromium.org/159187/diff/1005/1007#newcode486
Line 486: gtk_box_pack_start(GTK_BOX(button_hbox), show_cookies_button,
y'know, I think it's part of the gnome HIG that all action buttons for a dialog
(accept, cancel, etc.) ought to be the same size independent of their contents
(so they are all as big as the largest one). I don't particularly care about it
and I know it applies elsewhere as well. Just thought I'd mention it.

http://codereview.chromium.org/159187/diff/1005/1010
File chrome/browser/gtk/options/cookies_view.cc (right):

http://codereview.chromium.org/159187/diff/1005/1010#newcode42
Line 42: // TODO(mattm): these functions are also in url_picker_dialog_gtk..
move them to
nit: two periods

http://codereview.chromium.org/159187/diff/1005/1010#newcode73
Line 73: } // anonymous namespace.
two spaces before //
(also usually this is just "//  namespace" but I don't know if that's overly
important)

[mattm, 2009-07-22 19:20:46]

http://codereview.chromium.org/159187/diff/1005/1007
File chrome/browser/gtk/options/advanced_contents_gtk.cc (right):

http://codereview.chromium.org/159187/diff/1005/1007#newcode486
Line 486: gtk_box_pack_start(GTK_BOX(button_hbox), show_cookies_button,
On 2009/07/22 03:36:32, Evan Stade wrote:
> y'know, I think it's part of the gnome HIG that all action buttons for a
dialog
> (accept, cancel, etc.) ought to be the same size independent of their contents
> (so they are all as big as the largest one). I don't particularly care about
it
> and I know it applies elsewhere as well. Just thought I'd mention it.

Hm, but this isn't one of the action buttons?   All the action buttons are in a
gtk_button_box (dialog->action_area) that should take care of making them the
same size..

http://codereview.chromium.org/159187/diff/1005/1010
File chrome/browser/gtk/options/cookies_view.cc (right):

http://codereview.chromium.org/159187/diff/1005/1010#newcode42
Line 42: // TODO(mattm): these functions are also in url_picker_dialog_gtk..
move them to
On 2009/07/22 03:36:32, Evan Stade wrote:
> nit: two periods

Done.

http://codereview.chromium.org/159187/diff/1005/1010#newcode73
Line 73: } // anonymous namespace.
On 2009/07/22 03:36:32, Evan Stade wrote:
> two spaces before //
> (also usually this is just "//  namespace" but I don't know if that's overly
> important)

Done.

[Evan Stade, 2009-07-22 19:22:50]

lgtm still stands

http://codereview.chromium.org/159187/diff/1005/1007
File chrome/browser/gtk/options/advanced_contents_gtk.cc (right):

http://codereview.chromium.org/159187/diff/1005/1007#newcode486
Line 486: gtk_box_pack_start(GTK_BOX(button_hbox), show_cookies_button,
nevermind me