Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1591843003: Add back one test that still fails and remove a bunch of tests that now pass with the refactor. (Closed)

Created:
4 years, 11 months ago by Jacob
Modified:
4 years, 11 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add back one test that still fails and remove a bunch of tests that now pass with the refactor. BUG= Committed: https://github.com/dart-lang/sdk/commit/1be2db9a0589455ce5561b33f0d56c2d99c49c4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M tests/co19/co19-dartium.status View 7 chunks +0 lines, -12 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Updating test expectations files to reflect tests that now pass and a test that still ...
4 years, 11 months ago (2016-01-15 22:41:45 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as 1be2db9a0589455ce5561b33f0d56c2d99c49c4c (presubmit successful).
4 years, 11 months ago (2016-01-15 22:42:11 UTC) #4
Alan Knight
4 years, 11 months ago (2016-01-15 22:54:20 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698