Issue 1591833002: XFA: Add another valid fxcodec DEPS entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1591833002: XFA: Add another valid fxcodec DEPS entry. (Closed)

Created:
4 years, 11 months ago by Lei Zhang

Modified:
4 years, 11 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

XFA: Add another valid fxcodec DEPS entry. TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f30e663cd52e3304dfaea640cb410eeca018ed4f

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	core/src/fxcodec/codec/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

TBR After this, the only two left are: fpdfsdk/src/javascript/JS_Runtime.cpp Illegal include: "xfa/src/fxjse/src/value.h" xfa/src/fxjse/src/runtime.cpp Illegal include: ...

4 years, 11 months ago (2016-01-15 20:28:43 UTC) #1

Lei Zhang

4 years, 11 months ago (2016-01-15 20:28:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f30e663cd52e3304dfaea640cb410eeca018ed4f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages