Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 159182: Fix a FORWARD_NULL defect reported by Coverity.... (Closed)

Created:
11 years, 5 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
klink, Jonas Klink (Google)
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Fix a FORWARD_NULL defect reported by Coverity. In ChromeClientImpl::focus(), we need to do a null check for 'delegate' before calling delegate->FocusAccessibilityObject(). R=klink BUG=http://crbug.com/17101 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21296

Patch Set 1 #

Patch Set 2 : Upload before checkin #

Patch Set 3 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M webkit/glue/chrome_client_impl.cc View 1 2 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wtc
Hi Jonas, The obvious fix is to change if (focused_acc_obj) { delegate->FocusAccessibilityObject(focused_acc_obj); } to if ...
11 years, 5 months ago (2009-07-22 02:00:46 UTC) #1
Jonas Klink (Google)
11 years, 5 months ago (2009-07-22 17:34:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698