Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1591813002: Make //gpu/* pass gn check (and make it gn checked). (Closed)

Created:
4 years, 11 months ago by viettrungluu
Modified:
4 years, 11 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make //gpu/* pass gn check (and make it gn checked). (Also add //fusl/* to the list.) R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a6cf56896c3b49e5d07b7f3faf24343169b021bb

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M .gn View 2 chunks +8 lines, -2 lines 0 comments Download
M gpu/BUILD.gn View 7 chunks +7 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 6 chunks +14 lines, -11 lines 0 comments Download
M gpu/command_buffer/client/buffer_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 11 months ago (2016-01-15 19:27:05 UTC) #1
kulakowski
otherwise lgtm https://codereview.chromium.org/1591813002/diff/1/gpu/command_buffer/common/gles2_cmd_utils.cc File gpu/command_buffer/common/gles2_cmd_utils.cc (right): https://codereview.chromium.org/1591813002/diff/1/gpu/command_buffer/common/gles2_cmd_utils.cc#newcode15 gpu/command_buffer/common/gles2_cmd_utils.cc:15: //#include "gpu/command_buffer/common/gles2_cmd_format.h" Any reason to leave it ...
4 years, 11 months ago (2016-01-15 19:30:12 UTC) #2
viettrungluu
On 2016/01/15 19:30:12, kulakowski wrote: > otherwise lgtm > > https://codereview.chromium.org/1591813002/diff/1/gpu/command_buffer/common/gles2_cmd_utils.cc > File gpu/command_buffer/common/gles2_cmd_utils.cc (right): ...
4 years, 11 months ago (2016-01-15 20:36:49 UTC) #3
viettrungluu
4 years, 11 months ago (2016-01-15 20:37:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a6cf56896c3b49e5d07b7f3faf24343169b021bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698