Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 15917012: MIPS: Support Smi in CompareIDAndBranch (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1547 LOperand* left = UseFixed(instr->left(), a1); 1547 LOperand* left = UseFixed(instr->left(), a1);
1548 LOperand* right = UseFixed(instr->right(), a0); 1548 LOperand* right = UseFixed(instr->right(), a0);
1549 LCmpT* result = new(zone()) LCmpT(left, right); 1549 LCmpT* result = new(zone()) LCmpT(left, right);
1550 return MarkAsCall(DefineFixed(result, v0), instr); 1550 return MarkAsCall(DefineFixed(result, v0), instr);
1551 } 1551 }
1552 1552
1553 1553
1554 LInstruction* LChunkBuilder::DoCompareIDAndBranch( 1554 LInstruction* LChunkBuilder::DoCompareIDAndBranch(
1555 HCompareIDAndBranch* instr) { 1555 HCompareIDAndBranch* instr) {
1556 Representation r = instr->representation(); 1556 Representation r = instr->representation();
1557 if (r.IsInteger32()) { 1557 if (r.IsSmiOrInteger32()) {
1558 ASSERT(instr->left()->representation().IsInteger32()); 1558 ASSERT(instr->left()->representation().IsSmiOrInteger32());
1559 ASSERT(instr->right()->representation().IsInteger32()); 1559 ASSERT(instr->left()->representation().Equals(
1560 instr->right()->representation()));
1560 LOperand* left = UseRegisterOrConstantAtStart(instr->left()); 1561 LOperand* left = UseRegisterOrConstantAtStart(instr->left());
1561 LOperand* right = UseRegisterOrConstantAtStart(instr->right()); 1562 LOperand* right = UseRegisterOrConstantAtStart(instr->right());
1562 return new(zone()) LCmpIDAndBranch(left, right); 1563 return new(zone()) LCmpIDAndBranch(left, right);
1563 } else { 1564 } else {
1564 ASSERT(r.IsDouble()); 1565 ASSERT(r.IsDouble());
1565 ASSERT(instr->left()->representation().IsDouble()); 1566 ASSERT(instr->left()->representation().IsDouble());
1566 ASSERT(instr->right()->representation().IsDouble()); 1567 ASSERT(instr->right()->representation().IsDouble());
1567 LOperand* left = UseRegisterAtStart(instr->left()); 1568 LOperand* left = UseRegisterAtStart(instr->left());
1568 LOperand* right = UseRegisterAtStart(instr->right()); 1569 LOperand* right = UseRegisterAtStart(instr->right());
1569 return new(zone()) LCmpIDAndBranch(left, right); 1570 return new(zone()) LCmpIDAndBranch(left, right);
(...skipping 928 matching lines...) Expand 10 before | Expand all | Expand 10 after
2498 2499
2499 2500
2500 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2501 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2501 LOperand* object = UseRegister(instr->object()); 2502 LOperand* object = UseRegister(instr->object());
2502 LOperand* index = UseRegister(instr->index()); 2503 LOperand* index = UseRegister(instr->index());
2503 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2504 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2504 } 2505 }
2505 2506
2506 2507
2507 } } // namespace v8::internal 2508 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698