Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 15917010: Fix alpha computation in SkArithmeticMode. (Closed)

Created:
7 years, 6 months ago by Stephen White
Modified:
7 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix alpha computation in SkArithmeticMode. Note: this will require new baselines for the arithmode GM. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=9302

Patch Set 1 #

Patch Set 2 : Add testcase to arithmode GM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M gm/arithmode.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
reed@: PTAL. Thanks!
7 years, 6 months ago (2013-05-28 17:42:06 UTC) #1
reed1
lgtm good catch.
7 years, 6 months ago (2013-05-28 18:38:53 UTC) #2
Stephen White
7 years, 6 months ago (2013-05-28 19:43:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r9302 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698