Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1591663003: Move pre_read_field_trial_utils.h/cc to common/. (Closed)

Created:
4 years, 11 months ago by fdoray
Modified:
4 years, 11 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move pre_read_field_trial_utils.h/cc to common/. Move pre_read_field_trial_utils.h/cc from components/startup_metric_utils/browser/ to components/startup_metric_utils/common/. The files needs to be moved because I'm working on code that will use them from chrome/common/. BUG=577698 Committed: https://crrev.com/c295b761c340008220e8e0dde7af6e0d215fc99f Cr-Commit-Position: refs/heads/master@{#370151}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -213 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 2 comments Download
M chrome/app/main_dll_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/startup_metric_utils.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M components/startup_metric_utils/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/startup_metric_utils/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/startup_metric_utils/browser/pre_read_field_trial_utils_win.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/startup_metric_utils/browser/pre_read_field_trial_utils_win.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M components/startup_metric_utils/common/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/startup_metric_utils/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/startup_metric_utils/common/pre_read_field_trial_utils_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/startup_metric_utils/common/pre_read_field_trial_utils_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
fdoray
gab@chromium.org: Please review changes in components/startup_metric_utils/ jochen@chromium.org: Please review changes in chrome/ and components/startup_metric_utils.gypi
4 years, 11 months ago (2016-01-15 20:23:21 UTC) #2
gab
lgtm
4 years, 11 months ago (2016-01-16 01:36:08 UTC) #3
jochen (gone - plz use gerrit)
the CL description says "...to components/startup_metric_utils/components/." shouldn't that be ".../common/." ? https://codereview.chromium.org/1591663003/diff/1/chrome/app/DEPS File chrome/app/DEPS (right): ...
4 years, 11 months ago (2016-01-19 17:18:14 UTC) #4
fdoray
I fixed the description. jochen@: Can you take another look? https://codereview.chromium.org/1591663003/diff/1/chrome/app/DEPS File chrome/app/DEPS (right): https://codereview.chromium.org/1591663003/diff/1/chrome/app/DEPS#newcode23 ...
4 years, 11 months ago (2016-01-19 17:21:24 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-19 17:23:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591663003/1
4 years, 11 months ago (2016-01-19 17:39:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 18:49:31 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 18:50:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c295b761c340008220e8e0dde7af6e0d215fc99f
Cr-Commit-Position: refs/heads/master@{#370151}

Powered by Google App Engine
This is Rietveld 408576698