plumb through enableAsync

plumb through enableAsync
and mock async library elements if enableAsync is false

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/b7303a3409907145b87b14811906dae1da21122b

[danrubel, 2016-01-15 18:33:08]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-15 18:59:51]

LGTM

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/co...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/context/context.dart:726: new
CompilationUnitElementImpl("async.dart");
Do we ever use the file name to identify the library (I'm hoping the answer is
that we only use the library name)? If not, might it aid in debugging if we make
the file name something like "mock_async.dart"?

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/dart.dart:1721: if
(!context.analysisOptions.enableAsync) {
Not sure why we need to do this. If we create a mock library when appropriate,
when would the input (asyncLibrary) ever not already be the mock library?

[danrubel, 2016-01-15 19:14:30]

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/co...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/context/context.dart:726: new
CompilationUnitElementImpl("async.dart");
On 2016/01/15 18:59:50, Brian Wilkerson wrote:
> Do we ever use the file name to identify the library (I'm hoping the answer is
> that we only use the library name)? If not, might it aid in debugging if we
make
> the file name something like "mock_async.dart"?

Good suggestion. Done.

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1591653003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/dart.dart:1721: if
(!context.analysisOptions.enableAsync) {
On 2016/01/15 18:59:50, Brian Wilkerson wrote:
> Not sure why we need to do this. If we create a mock library when appropriate,
> when would the input (asyncLibrary) ever not already be the mock library?

We create mock elements to satisfy the typeProvider, but we do not add that mock
library element to the collection of dart:* libraries.
getRequiredInput(ASYNC_INPUT) will return null if there is no dart:async library
in the collection.

[danrubel, 2016-01-15 19:15:07]

Description was changed from

==========
plumb through enableAsync
and mock async library elements if enableAsync is false
==========

to

==========
plumb through enableAsync
and mock async library elements if enableAsync is false

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b7303a3409907145b87b14811906dae1da21122b
==========

[danrubel, 2016-01-15 19:15:08]

Committed patchset #3 (id:40001) manually as
b7303a3409907145b87b14811906dae1da21122b (presubmit successful).