Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1591573004: - Fix Isolate.spawn when running from snapshot. (Closed)

Created:
4 years, 11 months ago by Ivan Posva
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Fix Isolate.spawn when running from snapshot. - Avoid access to Isolate.resolvePackageUri when not needed. Fixes Dartium based test. TBR Committed: https://github.com/dart-lang/sdk/commit/28412d153e93c9421b1bfc6b304960d7de408169

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -38 lines) Patch
M runtime/bin/platform_patch.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/isolate.cc View 2 chunks +10 lines, -14 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 6 chunks +27 lines, -9 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Ivan Posva
TBR
4 years, 11 months ago (2016-01-15 07:20:57 UTC) #3
Ivan Posva
Committed patchset #2 (id:20001) manually as 28412d153e93c9421b1bfc6b304960d7de408169 (presubmit successful).
4 years, 11 months ago (2016-01-15 07:24:11 UTC) #5
rmacnak
4 years, 11 months ago (2016-01-15 18:33:16 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698