Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 1591543002: Only CHECK for RenderProcessHosts that outlive an incognito profile in release (Closed)

Created:
4 years, 11 months ago by mark a. foltz
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only CHECK for RenderProcessHosts that outlive an incognito profile in release builds. This is in the hope that a reproducible case will yield an informative crash dump to identify why the RPH is being leaked. BUG=496653 Committed: https://crrev.com/f655e6badb80175e5bca7f2eb63345bbd82fbafb Cr-Commit-Position: refs/heads/master@{#370155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/profiles/profile_destroyer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
mark a. foltz
4 years, 11 months ago (2016-01-15 20:26:30 UTC) #2
Avi (use Gerrit)
lgtm Fingers crossed.
4 years, 11 months ago (2016-01-15 20:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591543002/1
4 years, 11 months ago (2016-01-19 05:40:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/136620)
4 years, 11 months ago (2016-01-19 05:48:12 UTC) #7
mark a. foltz
4 years, 11 months ago (2016-01-19 18:33:54 UTC) #9
mark a. foltz
+anthonyvd for OWNERS review
4 years, 11 months ago (2016-01-19 18:34:10 UTC) #10
anthonyvd
lgtm Good luck trying to figure this out!
4 years, 11 months ago (2016-01-19 18:44:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591543002/1
4 years, 11 months ago (2016-01-19 18:53:01 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 18:58:32 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 18:59:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f655e6badb80175e5bca7f2eb63345bbd82fbafb
Cr-Commit-Position: refs/heads/master@{#370155}

Powered by Google App Engine
This is Rietveld 408576698