Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: cc/tiles/tile_manager_perftest.cc

Issue 1591513002: cc: Early out of UpdateTiles for resoureceless draw (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix perftests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/fake_picture_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/tile_manager_perftest.cc
diff --git a/cc/tiles/tile_manager_perftest.cc b/cc/tiles/tile_manager_perftest.cc
index 07bbb2b618cde7d2356f71f8e6b2d3e65a14422a..53b7ba819baf9285be3f1581711d01a26eaf7398 100644
--- a/cc/tiles/tile_manager_perftest.cc
+++ b/cc/tiles/tile_manager_perftest.cc
@@ -187,9 +187,8 @@ class TileManagerPerfTest : public testing::Test {
int priority_count = 0;
std::vector<FakePictureLayerImpl*> layers = CreateLayers(layer_count, 10);
- bool resourceless_software_draw = false;
for (const auto& layer : layers)
- layer->UpdateTiles(resourceless_software_draw);
+ layer->UpdateTiles();
timer_.Reset();
do {
@@ -215,9 +214,8 @@ class TileManagerPerfTest : public testing::Test {
NEW_CONTENT_TAKES_PRIORITY};
std::vector<FakePictureLayerImpl*> layers = CreateLayers(layer_count, 100);
- bool resourceless_software_draw = false;
for (const auto& layer : layers)
- layer->UpdateTiles(resourceless_software_draw);
+ layer->UpdateTiles();
int priority_count = 0;
timer_.Reset();
@@ -251,9 +249,8 @@ class TileManagerPerfTest : public testing::Test {
int priority_count = 0;
std::vector<FakePictureLayerImpl*> layers = CreateLayers(layer_count, 10);
- bool resourceless_software_draw = false;
for (const auto& layer : layers) {
- layer->UpdateTiles(resourceless_software_draw);
+ layer->UpdateTiles();
for (size_t i = 0; i < layer->num_tilings(); ++i) {
tile_manager()->InitializeTilesWithResourcesForTesting(
layer->tilings()->tiling_at(i)->AllTilesForTesting());
@@ -286,9 +283,8 @@ class TileManagerPerfTest : public testing::Test {
std::vector<FakePictureLayerImpl*> layers =
CreateLayers(layer_count, tile_count);
- bool resourceless_software_draw = false;
for (const auto& layer : layers) {
- layer->UpdateTiles(resourceless_software_draw);
+ layer->UpdateTiles();
for (size_t i = 0; i < layer->num_tilings(); ++i) {
tile_manager()->InitializeTilesWithResourcesForTesting(
layer->tilings()->tiling_at(i)->AllTilesForTesting());
@@ -396,11 +392,10 @@ class TileManagerPerfTest : public testing::Test {
CreateLayers(layer_count, approximate_tile_count_per_layer);
timer_.Reset();
- bool resourceless_software_draw = false;
do {
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(1));
for (const auto& layer : layers)
- layer->UpdateTiles(resourceless_software_draw);
+ layer->UpdateTiles();
GlobalStateThatImpactsTilePriority global_state(GlobalStateForTest());
tile_manager()->PrepareTiles(global_state);
« no previous file with comments | « cc/test/fake_picture_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698