Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 1591513002: cc: Early out of UpdateTiles for resoureceless draw (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix perftests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.h ('k') | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index 3caa20721de2b29b1a09262cae941b025117fac2..93d9bf1473bfffc9c792aca41021151615b22b96 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -412,12 +412,7 @@ void PictureLayerImpl::AppendQuads(RenderPass* render_pass,
CleanUpTilingsOnActiveLayer(last_append_quads_tilings_);
}
-bool PictureLayerImpl::UpdateTiles(bool resourceless_software_draw) {
- if (!resourceless_software_draw) {
- visible_rect_for_tile_priority_ = visible_layer_rect();
- screen_space_transform_for_tile_priority_ = ScreenSpaceTransform();
- }
-
+bool PictureLayerImpl::UpdateTiles() {
if (!CanHaveTilings()) {
ideal_page_scale_ = 0.f;
ideal_device_scale_ = 0.f;
@@ -494,17 +489,17 @@ bool PictureLayerImpl::UpdateTiles(bool resourceless_software_draw) {
}
void PictureLayerImpl::UpdateViewportRectForTilePriorityInContentSpace() {
- // If visible_rect_for_tile_priority_ is empty or
- // viewport_rect_for_tile_priority is set to be different from the device
- // viewport, try to inverse project the viewport into layer space and use
- // that. Otherwise just use visible_rect_for_tile_priority_
- gfx::Rect visible_rect_in_content_space = visible_rect_for_tile_priority_;
+ // If visible_layer_rect() is empty or viewport_rect_for_tile_priority is
+ // set to be different from the device viewport, try to inverse project the
+ // viewport into layer space and use that. Otherwise just use
+ // visible_layer_rect().
+ gfx::Rect visible_rect_in_content_space = visible_layer_rect();
gfx::Rect viewport_rect_for_tile_priority =
layer_tree_impl()->ViewportRectForTilePriority();
if (visible_rect_in_content_space.IsEmpty() ||
layer_tree_impl()->DeviceViewport() != viewport_rect_for_tile_priority) {
gfx::Transform view_to_layer(gfx::Transform::kSkipInitialization);
- if (screen_space_transform_for_tile_priority_.GetInverse(&view_to_layer)) {
+ if (ScreenSpaceTransform().GetInverse(&view_to_layer)) {
// Transform from view space to content space.
visible_rect_in_content_space = MathUtil::ProjectEnclosingClippedRect(
view_to_layer, viewport_rect_for_tile_priority);
« no previous file with comments | « cc/layers/picture_layer_impl.h ('k') | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698