Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 15915005: BuildLumaHistogram() attempts to access Skia pixel data directly. This isn't (Closed)

Created:
7 years, 7 months ago by Peter Kasting
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

BuildLumaHistogram() attempts to access Skia pixel data directly. This isn't correct because the data may need to be unpremultiplied. Use the appropriate functions for doing this. BUG=none TEST=none R=erg@chromium.org, reed@google.com, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ui/gfx/color_utils.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
This change was not made because I saw a real bug, but rather because I ...
7 years, 7 months ago (2013-05-23 22:55:48 UTC) #1
reed1
lgtm I definitely like the change where we don't assume that the pixels are already ...
7 years, 7 months ago (2013-05-24 11:50:48 UTC) #2
Elliot Glaysher
lgtm
7 years, 7 months ago (2013-05-24 17:59:10 UTC) #3
sky
LGTM
7 years, 7 months ago (2013-05-24 19:23:32 UTC) #4
Peter Kasting
7 years, 7 months ago (2013-05-24 19:25:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r202144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698