chrome/installer/setup/install.cc - Issue 15915003: Removing deprecated DCHECK's that require App Launcher to be user-level only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.cc

Issue 15915003: Removing deprecated DCHECK's that require App Launcher to be user-level only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Deleting bogus warning message. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install.cc

diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc

index b8ebe94fd372897dac60815ae6fae078910fd018..51c3107d2f07dea499fe64f2ab5c6c059648dee8 100644

--- a/chrome/installer/setup/install.cc

+++ b/chrome/installer/setup/install.cc

@@ -536,8 +536,6 @@ InstallStatus InstallOrUpdateProduct(

installer_state.FindProduct(BrowserDistribution::CHROME_APP_HOST);

// Creates shortcuts for App Launcher.

if (app_launcher_product) {

- // TODO(huangs): Remove this check once we have system-level App Host.

- DCHECK(!installer_state.system_install());

const base::FilePath app_host_exe(

installer_state.target_path().Append(kChromeAppHostExe));

InstallShortcutOperation app_launcher_shortcut_operation =

« no previous file with comments | « no previous file | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »