Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1591483003: XFA: Upgrade libpng to 1.6.20. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez, Sam Clegg
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 : more notes #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34020 lines, -72253 lines) Patch
A core/src/fxcodec/codec/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_png.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/image_diff_png.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 1 1 chunk +22 lines, -16 lines 0 comments Download
A third_party/libpng/0000-build-config.patch View 1 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/libpng/0001-disable-arm-neon.patch View 1 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/libpng/README.pdfium View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + third_party/libpng/png.h View 1 53 chunks +228 lines, -664 lines 0 comments Download
A + third_party/libpng/png.c View 1 1 chunk +4498 lines, -4297 lines 0 comments Download
A + third_party/libpng/pngconf.h View 1 1 chunk +622 lines, -617 lines 0 comments Download
A + third_party/libpng/pngdebug.h View 1 1 chunk +153 lines, -157 lines 0 comments Download
A + third_party/libpng/pngerror.c View 1 1 chunk +963 lines, -931 lines 0 comments Download
A + third_party/libpng/pngget.c View 1 1 chunk +1219 lines, -1176 lines 0 comments Download
A + third_party/libpng/pnginfo.h View 1 1 chunk +259 lines, -260 lines 0 comments Download
A + third_party/libpng/pnglibconf.h View 1 1 chunk +214 lines, -211 lines 0 comments Download
A + third_party/libpng/pngmem.c View 1 1 chunk +287 lines, -281 lines 0 comments Download
A + third_party/libpng/pngpread.c View 1 1 chunk +1085 lines, -1290 lines 0 comments Download
A + third_party/libpng/pngpriv.h View 1 1 chunk +1929 lines, -2010 lines 0 comments Download
A + third_party/libpng/pngread.c View 1 1 chunk +4136 lines, -3999 lines 0 comments Download
A + third_party/libpng/pngrio.c View 1 1 chunk +120 lines, -117 lines 0 comments Download
A + third_party/libpng/pngrtran.c View 1 1 chunk +4997 lines, -5102 lines 0 comments Download
A + third_party/libpng/pngrutil.c View 1 1 chunk +4529 lines, -4471 lines 0 comments Download
A + third_party/libpng/pngset.c View 1 1 chunk +1647 lines, -1596 lines 0 comments Download
A + third_party/libpng/pngstruct.h View 1 1 chunk +483 lines, -489 lines 0 comments Download
A + third_party/libpng/pngtrans.c View 1 1 chunk +849 lines, -840 lines 0 comments Download
A + third_party/libpng/pngwio.c View 1 1 chunk +168 lines, -163 lines 0 comments Download
A + third_party/libpng/pngwrite.c View 1 1 chunk +2230 lines, -2329 lines 0 comments Download
A + third_party/libpng/pngwtran.c View 1 1 chunk +576 lines, -636 lines 0 comments Download
A + third_party/libpng/pngwutil.c View 1 1 chunk +2709 lines, -3022 lines 0 comments Download
D third_party/lpng_v163/png.h View 1 1 chunk +0 lines, -3566 lines 0 comments Download
D third_party/lpng_v163/png.c View 1 1 chunk +0 lines, -4297 lines 0 comments Download
D third_party/lpng_v163/pngconf.h View 1 1 chunk +0 lines, -617 lines 0 comments Download
D third_party/lpng_v163/pngdebug.h View 1 1 chunk +0 lines, -157 lines 0 comments Download
D third_party/lpng_v163/pngerror.c View 1 1 chunk +0 lines, -931 lines 0 comments Download
D third_party/lpng_v163/pngget.c View 1 1 chunk +0 lines, -1176 lines 0 comments Download
D third_party/lpng_v163/pnginfo.h View 1 1 chunk +0 lines, -260 lines 0 comments Download
D third_party/lpng_v163/pnglibconf.h View 1 1 chunk +0 lines, -211 lines 0 comments Download
D third_party/lpng_v163/pngmem.c View 1 1 chunk +0 lines, -281 lines 0 comments Download
D third_party/lpng_v163/pngpread.c View 1 1 chunk +0 lines, -1290 lines 0 comments Download
D third_party/lpng_v163/pngpriv.h View 1 1 chunk +0 lines, -2010 lines 0 comments Download
D third_party/lpng_v163/pngread.c View 1 1 chunk +0 lines, -3999 lines 0 comments Download
D third_party/lpng_v163/pngrio.c View 1 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/lpng_v163/pngrtran.c View 1 1 chunk +0 lines, -5102 lines 0 comments Download
D third_party/lpng_v163/pngrutil.c View 1 1 chunk +0 lines, -4471 lines 0 comments Download
D third_party/lpng_v163/pngset.c View 1 1 chunk +0 lines, -1596 lines 0 comments Download
D third_party/lpng_v163/pngstruct.h View 1 1 chunk +0 lines, -489 lines 0 comments Download
D third_party/lpng_v163/pngtrans.c View 1 1 chunk +0 lines, -840 lines 0 comments Download
D third_party/lpng_v163/pngwio.c View 1 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/lpng_v163/pngwrite.c View 1 1 chunk +0 lines, -2329 lines 0 comments Download
D third_party/lpng_v163/pngwtran.c View 1 1 chunk +0 lines, -636 lines 0 comments Download
D third_party/lpng_v163/pngwutil.c View 1 1 chunk +0 lines, -3022 lines 0 comments Download
M third_party/third_party.gyp View 1 1 chunk +22 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
4 years, 11 months ago (2016-01-15 01:53:06 UTC) #4
Lei Zhang
Not going to bother with the upgrade on master: - master is a dead end ...
4 years, 11 months ago (2016-01-15 01:57:02 UTC) #5
Tom Sepez
RS LGTM
4 years, 11 months ago (2016-01-15 19:50:07 UTC) #6
Lei Zhang
4 years, 11 months ago (2016-01-15 20:20:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:30001) manually as
fa92864d257f57e5afdc0a36eafad8f2575c528a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698