Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1591483002: Prepare for chaining resynthesizers from AC to SDK AC. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prepare for chaining resynthesizers from AC to SDK AC. AboutToComputeResultHelper for each AnalysisContext should be set externally, because analysis engine does not know where summaries are stored. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/37c2eca20d591f3ae08befaa1222d519d0e04ea4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fallback to the SDK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -338 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 4 chunks +43 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 4 chunks +32 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 6 chunks +51 lines, -32 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 1 chunk +8 lines, -4 lines 0 comments Download
D pkg/analyzer/test/src/summary/summary_sdk_test.dart View 1 chunk +0 lines, -260 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 11 months ago (2016-01-14 22:35:27 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1591483002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1591483002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode525 pkg/analyzer/lib/src/context/context.dart:525: return aboutToComputeResultHelper.compute(entry, result); Shouldn't this fall through to ...
4 years, 11 months ago (2016-01-14 22:45:28 UTC) #2
scheglov
https://codereview.chromium.org/1591483002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1591483002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode525 pkg/analyzer/lib/src/context/context.dart:525: return aboutToComputeResultHelper.compute(entry, result); On 2016/01/14 22:45:28, Brian Wilkerson wrote: ...
4 years, 11 months ago (2016-01-14 22:51:35 UTC) #3
scheglov
4 years, 11 months ago (2016-01-17 17:25:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
37c2eca20d591f3ae08befaa1222d519d0e04ea4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698