Issue 159143003: android envsetup: Stop setting branding=Chrome buildtype=Official.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159143003: android envsetup: Stop setting branding=Chrome buildtype=Official. (Closed)

Created:
6 years, 10 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
Yaron

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android envsetup: Stop setting branding=Chrome buildtype=Official. They are now set by the internal build script that also sets CHROME_ANDROID_OFFICIAL_BUILD ( https://chrome-internal-review.googlesource.com/154265 ). No intended behavior change. BUG=330631 R=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250296

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yaron

On 2014/02/11 02:04:34, Nico (away Feb 11 - Feb 17) wrote: lgtm

6 years, 10 months ago (2014-02-11 02:28:29 UTC) #2

Nico

6 years, 10 months ago (2014-02-11 02:39:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r250296 (tree was closed).

Expand Messages | Collapse Messages