Make CSSStyleDeclaration getter/setter custom

Make CSSStyleDeclaration getter/setter custom

This patch contains revert of
151201: Auto-generate V8CSSStyleDeclaration::namedPropertyGetter
http://src.chromium.org/viewvc/blink?view=revision&revision=151201

Because of the performance regression:
https://code.google.com/p/chromium/issues/detail?id=244432

I made this new patch because It's hard to revert only 151201
because there is lots of changes in code generator and IDL attributes.

R=haraken@chromium.org
BUG=229740
TEST=No tests.
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151460

[kojih, 2013-05-30 03:27:42]

r?

Diff of generated code:

-v8::Handle<v8::Value>
V8CSSStyleDeclaration::namedPropertyGetter(v8::Local<v8::String> name, const
v8::AccessorInfo& info)
-{
-    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
-        return v8Undefined();
-    if (info.Holder()->HasRealNamedCallbackProperty(name))
-        return v8Undefined();
-
-    ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
-    CSSStyleDeclaration* collection = toNative(info.Holder());
-    AtomicString propertyName = toWebCoreAtomicString(name);
-    bool element0Enabled = false;
-    String element0;
-    bool element1Enabled = false;
-    float element1;
-    collection->anonymousNamedGetter(propertyName, element0Enabled, element0,
element1Enabled, element1);
-    if (element0Enabled)
-        return v8StringOrNull(element0, info.GetIsolate());
-    if (element1Enabled)
-        return v8::Number::New(element1);
-    return v8Undefined();
-}
-
-v8::Handle<v8::Value>
V8CSSStyleDeclaration::namedPropertySetter(v8::Local<v8::String> name,
v8::Local<v8::Value> value, const v8::AccessorInfo& info)
-{
-    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
-        return v8Undefined();
-    if (info.Holder()->HasRealNamedCallbackProperty(name))
-        return v8Undefined();
-    CSSStyleDeclaration* collection = toNative(info.Holder());
-    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);
-    ExceptionCode ec = 0;
-    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<WithNullCheck>,
propertyValue, value);
-    bool result = collection->anonymousNamedSetter(propertyName, propertyValue,
ec);
-    if (!result)
-        return v8Undefined();
-    if (ec)
-        return setDOMException(ec, info.GetIsolate());
-    return value;
-}
-

[haraken, 2013-05-30 04:44:23]

LGTM. Let's investigate the performance issue.

[commit-bot: I haz the power, 2013-05-30 05:34:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15914015/1

[commit-bot: I haz the power, 2013-05-30 08:55:05]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-30 09:02:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15914015/1

[commit-bot: I haz the power, 2013-05-30 11:27:37]

Change committed as 151460