Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 159133002: android envsetup: Don't set script-local variable toolchain_dir. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android envsetup: Don't set script-local variable toolchain_dir. Unused after r250141. No behavior change. BUG=330631 TBR=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M build/android/envsetup.sh View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
6 years, 10 months ago (2014-02-10 18:59:16 UTC) #1
Nico
Since this just deletes some dead code, I'll tbr this.
6 years, 10 months ago (2014-02-10 20:10:55 UTC) #2
Nico
Committed patchset #1 manually as r250187 (presubmit successful).
6 years, 10 months ago (2014-02-10 20:11:48 UTC) #3
Torne
6 years, 10 months ago (2014-02-11 10:49:29 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698